[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#380351: marked as done (hardcodes paths to grub-install and update-grub, rendering them "unmovable")

Your message dated Thu, 31 Aug 2006 15:32:12 -0700
with message-id <E1GIv52-0003dT-IK@spohr.debian.org>
and subject line Bug#380351: fixed in grub-installer 1.18
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: grub-installer
Severity: grave
Tags: patch

Using absolute paths can have horrid consequences as you've seen in #361929.
Now grub commands are "trapped" into violating FHS and being unable to move at
the same time.

Please find attached patch to switch to relative paths when invoking
grub-install or update-grub.

Note: The patch assumes that PATH env variable is properly set during execution
of these scripts.  If that's not the case, you'll have to export it explicitly,
either in grub-installer or whereever you find appropiate.

As for /etc/kernel-img.conf generation, it cannot yet be done using relative
paths, but I expect that we'll be able to fix this automaticaly from
kernel-package (see #380338).

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-amd64-k8
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)

diff -ur grub-installer-1.17.old/grub-installer grub-installer-1.17/grub-installer
--- grub-installer-1.17.old/grub-installer	2006-06-06 00:53:14.000000000 +0200
+++ grub-installer-1.17/grub-installer	2006-07-29 14:20:02.000000000 +0200
@@ -173,7 +173,7 @@
 
 # Run update-grub in $ROOT.
 update_grub () {
-	if ! log-output -t grub-installer $chroot $ROOT /sbin/update-grub -y ; then
+	if ! log-output -t grub-installer $chroot $ROOT update-grub -y ; then
 		error "Running 'update-grub -y' failed." 1>&2
 		db_input critical grub-installer/update-grub-failed || [ $? -eq 30 ]
 		db_go || true
@@ -338,7 +338,7 @@
 update_mtab
 
 if ! is_floppy "$bootdev"; then
-	if $chroot $ROOT /sbin/grub-install -h 2>&1 | grep -q no-floppy; then
+	if $chroot $ROOT grub-install -h 2>&1 | grep -q no-floppy; then
 		info "grub-install supports --no-floppy"
 		floppyparam="--no-floppy"
 	else
@@ -346,8 +346,8 @@
 	fi
 fi
 
-info "Running $chroot $ROOT /sbin/grub-install --recheck $floppyparam \"$bootdev\""
-if log-output -t grub-installer $chroot $ROOT /sbin/grub-install --recheck $floppyparam "$bootdev"; then
+info "Running $chroot $ROOT grub-install --recheck $floppyparam \"$bootdev\""
+if log-output -t grub-installer $chroot $ROOT grub-install --recheck $floppyparam "$bootdev"; then
 	info "grub-install ran successfully"
 else
 	error "Running 'grub-install --recheck $floppyparam \"$bootdev\"' failed."
diff -ur grub-installer-1.17.old/rescue.d/80grub-reinstall grub-installer-1.17/rescue.d/80grub-reinstall
--- grub-installer-1.17.old/rescue.d/80grub-reinstall	2006-01-17 00:04:04.000000000 +0100
+++ grub-installer-1.17/rescue.d/80grub-reinstall	2006-07-29 14:19:23.000000000 +0200
@@ -30,12 +30,12 @@
 update_mtab
 
 if ! is_floppy "$bootdev"; then
-	if chroot /target /sbin/grub-install -h 2>&1 | grep -q no-floppy; then
+	if chroot /target grub-install -h 2>&1 | grep -q no-floppy; then
 		floppyparam="--no-floppy"
 	fi
 fi
 
-if ! log-output -t grub-installer chroot /target /sbin/grub-install --recheck $floppyparam "$bootdev"; then
+if ! log-output -t grub-installer chroot /target grub-install --recheck $floppyparam "$bootdev"; then
 	db_subst grub-installer/grub-install-failed BOOTDEV "$bootdev"
 	db_input critical grub-installer/grub-install-failed BOOTDEV "$bootdev"
 	db_go || true

--- End Message ---
--- Begin Message --- 
Source: grub-installer
Source-Version: 1.18

We believe that the bug you reported is fixed in the latest version of
grub-installer, which is due to be installed in the Debian FTP archive:

grub-installer_1.18.dsc
  to pool/main/g/grub-installer/grub-installer_1.18.dsc
grub-installer_1.18.tar.gz
  to pool/main/g/grub-installer/grub-installer_1.18.tar.gz
grub-installer_1.18_i386.udeb
  to pool/main/g/grub-installer/grub-installer_1.18_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 380351@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Otavio Salvador <otavio@debian.org> (supplier of updated grub-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 31 Aug 2006 19:10:57 -0300
Source: grub-installer
Binary: grub-installer
Architecture: source i386
Version: 1.18
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Otavio Salvador <otavio@debian.org>
Description: 
 grub-installer - Install GRUB on a hard disk (udeb)
Closes: 380351 385180
Changes: 
 grub-installer (1.18) unstable; urgency=low
 .
   [ Joey Hess ]
   * Fix mistake in displaying failure message if grub-install run in rescue
     mode fails.
 .
   [ Simon Huggins ]
   * Allow installation to more than one disk if preseeding.
 .
   [ Otavio Salvador ]
   * Apply patch from Robert Millan <rmh@aybabtu.com> to removed hardcoded
     paths from grub-install and update-grub. Closes: #380351
   * Apply patch from Robert Millan <rmh@aybabtu.com> to allow use of grub2
     instead of grub legacy. Closes: 385180
 .
   [ Updated translations ]
   * Arabic (ar.po) by Ossama M. Khayat
   * Catalan (ca.po) by Jordi Mallach
   * Czech (cs.po) by Miroslav Kure
   * Danish (da.po) by Claus Hindsgaul
   * German (de.po) by Jens Seidel
   * Dzongkha (dz.po) by Jurmey Rabgay
   * Greek, Modern (1453-) (el.po) by quad-nrg.net
   * Esperanto (eo.po) by Serge Leblanc
   * Spanish (es.po) by Javier Fernández-Sanguino Peña
   * Estonian (et.po) by Siim Põder
   * Basque (eu.po) by Piarres Beobide
   * Finnish (fi.po) by Tapio Lehtonen
   * French (fr.po) by Christian Perrier
   * Galician (gl.po) by Jacobo Tarrio
   * Gujarati (gu.po) by Kartik Mistry
   * Hebrew (he.po) by Lior Kaplan
   * Hungarian (hu.po) by SZERVÃ?C Attila
   * Italian (it.po) by Giuseppe Sacco
   * Japanese (ja.po) by Kenshi Muto
   * Khmer (km.po) by Khoem Sokhem
   * Korean (ko.po) by Sunjae park
   * Lithuanian (lt.po) by KÄ?stutis BiliÅ«nas
   * Macedonian (mk.po) by Georgi Stanojevski
   * Norwegian Bokmål (nb.po) by Bjørn Steensrud
   * Dutch (nl.po) by Bart Cornelis
   * Panjabi (pa.po) by A S Alam
   * Polish (pl.po) by Bartosz Fenski
   * Portuguese (Brazil) (pt_BR.po) by André Luís Lopes
   * Portuguese (pt.po) by Miguel Figueiredo
   * Romanian (ro.po) by Eddy PetriÅ?or
   * Russian (ru.po) by Yuri Kozlov
   * Northern Sami (se.po) by Børre Gaup
   * Slovak (sk.po) by Peter Mann
   * Swedish (sv.po) by Daniel Nylander
   * Thai (th.po) by Theppitak Karoonboonyanan
   * Tagalog (tl.po) by Eric Pareja
   * Turkish (tr.po) by Recai OktaÅ?
   * Ukrainian (uk.po) by Eugeniy Meshcheryakov
   * Vietnamese (vi.po) by Clytie Siddall
   * Simplified Chinese (zh_CN.po) by Carlos Z.F. Liu
   * Traditional Chinese (zh_TW.po) by Tetralet
Files: 
 d5b5fd9ed9449b6a5e442aa12285c6a1 717 debian-installer standard grub-installer_1.18.dsc
 c1b0afdcd903da9afb4c8cef43b5f633 119358 debian-installer standard grub-installer_1.18.tar.gz
 1d8d25585daaa4437c228b8f0584039a 94510 debian-installer standard grub-installer_1.18_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)

iD8DBQFE918BLqiZQEml+FURAmizAJ4qVvQXW+1sG6A0vq473So65ZXqwgCgkXcI
pBxTHso7OOUnZjRoctCAKyM=
=hKpJ
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: