[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH] Better flexibility to control system base installation



Otavio Salvador wrote:
> +# Set initial value to includes and excludes
> +db_get base-installer/includes
> +INCLUDES="$RET" || true
> +
> +db_get base-installer/excludes
> +EXCLUDES="$RET" || true
> +
> +
>  log() {
>  	logger -t base-installer "$@"
>  }
> @@ -125,11 +131,11 @@
>  			COMPONENTS="*"
>  		fi
>  		if [ -s /cdrom/.disk/base_include ]; then
> -			INCLUDES=`grep -v '^#' /cdrom/.disk/base_include | tr '\n' , | sed 's/,$//'`
> +			INCLUDES="$INCLUDES,`grep -v '^#' /cdrom/.disk/base_include | tr '\n' , | sed 's/,$//'`"

This makes INCLUDES be set to ",foo,bar" if it comes from the CD only. Does
debootstrap actually support that syntax for --include and --exclude?
It's not documented to, and seems like the sort of thing that might
currently work by accident but should not be assumed to keep working.

> +			--print-debs \

Don't think you meant to leave this in.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: