[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#270136: marked as done (aparted_server.pid handling is not robust)

Your message dated Thu, 18 May 2006 16:02:19 -0700
with message-id <E1FgrVb-0000H7-Dt@spohr.debian.org>
and subject line Bug#270136: fixed in partman-base 83
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: partman
Severity: normal
Tags: d-i

Many times I have seen partman get confused about whether parted_server
was running, and hang or otherwise misbehave. This is always caused by
some other bug, but the bad handling of the pid file in partman
exerbates it.

For example, the most recent partman breakage is that libparted is not
loaded by anna. So parted_server fails to run at all. (This bug has been
fixed.) Normally this would result in partman putting up an error and
exiting, but due to the pid file handling, it results in an error and
then partman hanging.

Look at how the pid file is written:

init.d:

    parted_server &
    echo $! >/var/run/parted_server.pid

finish.d:

    open_infifo
    write_line "QUIT"
    close_infifo

    rm /var/run/parted_server.pid

The init.d code is buggy because even if parted_server fails to run or
crashes, a pid file will still be written.

The finish.d code is buggy because even if parted_server fails to stop
the pid file will be removed (and I've seen this result in two
parted_servers running, due to other bugs that made it not stop).

I think it would be much better if parted_server was a good daemon and
managed writing and unlinking its own pid file. This would eliminate both
these points of failure and make partman more robust.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.4.27
Locale: LANG=en_US, LC_CTYPE=en_US

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message --- 
Source: partman-base
Source-Version: 83

We believe that the bug you reported is fixed in the latest version of
partman-base, which is due to be installed in the Debian FTP archive:

partman-base_83.dsc
  to pool/main/p/partman-base/partman-base_83.dsc
partman-base_83.tar.gz
  to pool/main/p/partman-base/partman-base_83.tar.gz
partman-base_83_i386.udeb
  to pool/main/p/partman-base/partman-base_83_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 270136@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated partman-base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 18 May 2006 17:45:10 -0500
Source: partman-base
Binary: partman-base
Architecture: source i386
Version: 83
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 partman-base - Partition the storage devices (partman) (udeb)
Closes: 270136
Changes: 
 partman-base (83) unstable; urgency=low
 .
   [ Mark Hymers ]
   * Add more robust pid file and fifo handling.  Closes: #270136.
Files: 
 0c688c5b4e70fe52da9cdf862de52e55 694 debian-installer standard partman-base_83.dsc
 73a0e8533533dc0f110fdf17909785cd 157977 debian-installer standard partman-base_83.tar.gz
 694c98033c95f876ec09da8dd022dd96 140568 debian-installer standard partman-base_83_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEbPlZ2tp5zXiKP0wRAuK7AJ9sbP1cqE86GsJg8ce9IcV+r0h9gwCgvPLw
Cp6aXXtVHB04qDdn3XU0ANQ=
=az3m
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: