[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#365747: Fwd: [patch ] Add /dev/mapper in all cases needed in bsae-installer

On Wednesday 03 May 2006 20:29, Joey Hess wrote:
> Frans Pop wrote:
> > +		if pvdisplay | grep -iq "physical volume ---"; then
> > +			apt-install lvm2
> > +			mount -t proc proc /target/proc
> > +			chroot /target vgscan --mknodes || true
> > +			umount /target/proc
> > +		fi
> Doesn't lvm 1 work without device-mapper? If so then the pvdisplay if
> block should be moved to outside the other if block. Doing so seems
> safe anyway.

I agree with Riku. As the installer only supports lvm2 anyway, I don't see 
what the suggested change would add.
AFAIK we currently don't detect existing lvm1 partitions in partman in 
case you were thinking of supporting those, so that would probably need 
to be addressed first.

The original patch proposed in this BR makes minimal changes to existing 
code, so looks safest.

Attachment: pgpDRb02rDEyZ.pgp
Description: PGP signature

Reply to: