[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Some comments on partman-crypto templates



Some comments by Frans do not really discussion. So I'll apply changes
for all such comments, which leaves only the following without applied
change:

> > +# An initialization vector is the initial randomness used to seed
> > +# the encryption algorithm
> > +_Description: Initialization vector generation algorithm for this
> > partition:
> 
> I wonder if users will understand what this is about. Any reason why we 
> could not add some more text to explain this? After all, we have a whole 
> screen to play with...
> 
> I would guess that not all users trying encryption for their /home 
> directory will be used to the terminology.
> 
> Maybe it would be good to go through the questions in general from this 
> point of view.
> Something else to add could be a warning about performance consequences.

Completely agreed.

Proposal:

 Setting up encryption needs random data to be used by the encryption
 algorithm. This data can be obtained through various algorithms.
 Please choose the algorithm that should be used to initialize encryption.


> 
> > +Template: partman-crypto/keyhash
> > +Type: select
> > +Choices: ${choices}
> > +_Description: Type of encryption key hash for this partition:
> 
> Same here.

Proposal:

 The encryption key can be provided as a "hash" which is a one-way
 encryption of the key itself. Different hash algorithms can be
 used to create a hash.


> 
> > +Template: partman-crypto/module_package_missing
> > +Type: error
> > +_Description: Encryption package installation failure
> > + The kernel module package ${PACKAGE} could not be found or an error
> > + occurred during installation.
> 
> s/during installation/during its installation/

Commited


> 
> > + .
> > + There will likely be problems during boot when the system tries to
> > + setup encrypted partitions. You can still correct them by installing
> > + the required package later on.
> 
> Except if / is encrypted...
> 
> Proposal:
> "It is likely that there will be problems setting up encrypted partitions 
> when the system is rebooted. You may be able to correct this by 
> installing the required package(s) later on."

Seems fine by me. Commited.


> 
> > +Template: partman-crypto/confirm
> > +Type: boolean
> > +Default: false
> > +#flag:translate!:4
> > +_Description: Write the changes to disks and configure encrypted
> > volumes?
> 
> s/to disks/to disk/


Commited

> 
> > + Before encrypted volumes can be configured, the current 
> > + partitioning scheme has to be written to disk.  These changes
> > + cannot be undone.
> > + .
> > + After the encrypted volumes have been configured, no additional
> > + changes to the partitions in the disks containing encrypted volumes
> > + are allowed. Please decide if you are satisfied with the current
> > + partitioning scheme in these disks before continuing.
> 
> s/in the disks/on the disks/
> s/in these disks/for these disks/

Commited


> 
> > +Template: partman-crypto/confirm_nochanges
> > +Type: boolean
> > +Default: false
> > +_Description: Keep current partition layout and configure encrypted
> > volumes?
> > + After the encrypted volumes have been configured, no additional
> > changes
> > + to the partitions in the disks containing encrypted volumes are
> > + allowed. Please decide if you are satisfied with the current
> > + partitioning scheme in these disks before continuing.
> 
> Same.


Commited

> 
> > +
> > +Template: partman-crypto/commit_failed
> > +Type: error
> > +_Description: Encrypted volumes configuration failure
> 
> Hmm. Does not sound very nice. Not sure of better alternative.
> "Configuration of encrypted volumes failed" ???


Seems better. Commited

> 
> > + An error occurred while configuring encrypted volumes.
> > + .
> > + The configuration is aborted.
> 
> s/is aborted/has been aborted/


Commited

> 
> > +Template: partman-crypto/init_failed
> > +Type: error
> > +_Description: Encrypted volume initialisation failed
> 
> Same as last comment but one.

Commited, as above: "Initialisation of encrypted volume failed".

BTW, "initialisation" or "initialization". We usually did choose US
spelling...


> > + Please disable the swap space (e.g. by running swapoff) or configure
> > + an encrypted swap space and then run setup of encrypted volumes
> > again.
> > + This program will now abort. 
> 
> Will it really abort? Or will setting up encryption be broken off in a 
> controlled manner? Aborting to me means: please reboot your system and 
> start the installation from scratch.

Needs further discussion. Nothing commited


> 
> > +Template: partman-crypto/crypto_root_needs_boot
> > +Type: error
> > +_Description: Encryption configuration failure
> > + You have selected the root filesystem to be stored on an encrypted
> > + partition. This feature requires a separate /boot partition on which
> > + the kernel and initrd can be stored.
> > + .
> > + You should go back and configure a /boot partition.
> 
> s/configure/set up/ ???


Commited

> 
> > +Template: partman-crypto/crypto_boot_not_possible
> > +Type: error
> > +_Description: Encryption configuration failure
> > + You have selected the /boot filesystem to be stored on an encrypted
> > + partition. This is not possible because the kernel and initrds could
> > + then not be accessed by the bootloader. Continuing now would result
> > + in an installation that cannot be used.
> 
> s/because the kernel and initrds could then not be accessed by the 
> bootloader/because the bootloader would be unable to load the kernel and 
> initrd/

Commited

-- 


Attachment: signature.asc
Description: Digital signature


Reply to: