On Thu, Feb 09, 2006 at 05:41:38PM +0100, Frans Pop wrote: > On Thursday 09 February 2006 17:10, Geert Stappers wrote: > > -if ! db_get preseed/url || [ -z "$RET" ] ; then > > +db_get preseed/url || true > > +if [ -z "$RET" ]; then > > set_preseed_url > > fi > > Please explain why this change was made. Your commit message does not give > any clue, except maybe for vague aesthetic reasons? > > Why is the old code better? Because $RET will contain an error message in > some cases if db_get returns non-zero. The new code fails to check the > return code of the db_get command. > So you are now possibly setting your URL with random values. Mmm, I see. Thanks for telling. I have now moved the test for a sane preseed/url to 'network-preseed.isinstallable' GSt
Attachment:
signature.asc
Description: Digital signature