On Fri, Feb 03, 2006 at 10:56:41PM +0100, Frans Pop wrote:
> On Friday 03 February 2006 22:12, Geert Stappers wrote:
> > Any objections to upload it, so it gets into beta2?
>
> Yes. It is too late for Beta2
Mmm, pity.
> and IMO also needs serious review.
>
> I'd appreciate comments by others. Joey?
> On first glance the patch looks like it may break normal preseeding of
> preseed/url.
It indeed does/did.
The idea was/is that the patch obsoletes normal preseeding of preseed/url
Fixed in the update.
> Also, the coding style of the patch is completely inconsistent with the
> coding style of the rest of d-i and even the file in which the patch was
> made:
> - please use tabs to indent;
done
> - Please keep "then" on the same line as "if":
> if [ -r ${LEASE} ]; then
done
> I think you should quote at least ${FN##*://*} in the -z test.
done.
Does it make sense to added quotes on line 23 in the same file?
> I also wonder why the 2nd if is not nested inside the first one.
That is indeed better, done
> The line LEASE="notfound" is not needed if you'd just use:
> if [ -r "${LEASE}" ]; then
quotes added, line LEASE="notfound" is dropped.
> Cheers,
> FJP
> (with his D-I Release Manager hat on)
Respect
Geert Stappers
Attachment:
signature.asc
Description: Digital signature