[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [g-i] fonts: a few thoughts



On 2/1/06, Frans Pop <aragorn@tiscali.nl> wrote:
> > I have added the shift for now, but I think your patch is not very nice
> >
> > It searches the whole parameter string for the presence of the option,
> > but using a 'shift' if the parameter is present assumes that it is the
> > first parameter. This could lead to another parameter being removed
> > instead and maybe to the script failing.
> >
> > Is a better solution for checking the presence of the parameter
> > possible?

This should fix the issue with <XXXX--invertYYY> being equivalent to
<--invert> and also should fix the missing "endif" in the last if
statement.
=======================
--- strip_glyphs.pe.old Thu Feb  2 09:16:41 2006
+++ strip_glyphs.pe     Thu Feb  2 09:16:25 2006
@@ -33,7 +33,7 @@
 endif

 # If --invert is present, then we only include the selection
-if (Strstr($1, "--invert") != -1)
+if ( Strcasecmp($1, "--invert") == 0)
         use_inverted_selection = 1; shift
 else
         use_inverted_selection = 0
@@ -84,6 +84,7 @@

 if (use_inverted_selection == 1)
         SelectInvert()
+endif

 Clear()
=======================

--
Regards,
EddyP
=============================================
"Imagination is more important than knowledge" A.Einstein



Reply to: