[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#347479: partman-auto-lvm: Seems to not handle VG creation correctly



severity 347479 serious
retitle 347479 Seems to not handle VG creation correctly
thanks

The originally report seems to be only a symptom of a more structural 
problem in the script automatically_partition/some_device_lvm/do_option:

<snip>
# Choose name, create VG and attach each partition as a physical volume
noninteractive=true
while true; do
    db_input medium partman-auto-lvm/new_vg_name || eval $noninteractive
    db_go || exit 1
    db_get partman-auto-lvm/new_vg_name
    VG_name="$RET"

    if VG_create "$VG_name" $pv_devices; then break; fi
    noninteractive="exit 1"
done
</snip>

This seems to fail if a VG with the requested name already exists:
   /dev/Debian: already exists in filesystem
   New volume group name "Debian" is invalid
At high priority this error seems to be skipped over.
At medium priority this leads to the loop.

What happens if the user goes back and chooses a different name? Do VGs 
get created for both names?

Should a check be added before asking the question to see if the name is 
already in use?
Should the VG with the "old" name maybe be deleted first?
Should any existing VGs be reset/deleted anyway whenever the user selects 
to autopartition using LVM?
What happens if the user goes back and selects a different harddisk for 
autopartitioning using LVM?

This issue seems structural enough to make partman-auto-lvm unsuitable for 
inclusion in Beta2.

Attachment: pgp1kf7F6HQ_9.pgp
Description: PGP signature


Reply to: