[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#286265: marked as done (Partman hook for various checks on sparc)



Your message dated Wed, 11 Jan 2006 14:35:24 -0800
with message-id <E1EwoYu-0000ui-TB@spohr.debian.org>
and subject line Bug#286265: fixed in silo-installer 1.02
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 18 Dec 2004 22:48:15 +0000
>From aragorn@tiscali.nl Sat Dec 18 14:48:15 2004
Return-path: <aragorn@tiscali.nl>
Received: from 195-240-184-66-mx.xdsl.tiscali.nl (elrond.fjphome.nl) [195.240.184.66] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1CfnMz-00015H-00; Sat, 18 Dec 2004 14:48:14 -0800
Received: from strider.fjphome.nl ([10.19.66.89] ident=fjp)
	by elrond.fjphome.nl with esmtp (Exim 4.34)
	id 1CfnMS-00014m-9a; Sat, 18 Dec 2004 23:47:40 +0100
From: Frans Pop <aragorn@tiscali.nl>
To: jurij@wooyd.org,
 submit@bugs.debian.org
Subject: Re: Partman hook for various checks on sparc
Date: Sat, 18 Dec 2004 23:47:40 +0100
User-Agent: KMail/1.6.2
References: <Pine.LNX.4.61.0412181719060.11764@bobcat>
In-Reply-To: <Pine.LNX.4.61.0412181719060.11764@bobcat>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: Multipart/Mixed;
  boundary="Boundary-00=_MOLxBlu7z2EojOz"
Message-Id: <200412182347.40292.aragorn@tiscali.nl>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--Boundary-00=_MOLxBlu7z2EojOz
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: partman-target
Severity: wishlist

This way the patch won't get lost in the mailarchives...

On Saturday 18 December 2004 23:35, Jurij Smakov wrote:
> Hi,
>
> I've cooked up a little patch, implementing a finish.d hook for
> partman, which makes sure that the chosen partitioning scheme is sane
> enough for SILO to work properly. The script (finish.d/silo_check)
> identifies the partition where kernel is going to be installed (/boot,
> if it is present, otherwise /) and checks that a) it has a filesystem
> supported by SILO (ext[23] or ufs) and b) it fits entirely within the
> first gigabyte from the beginning of the disk on older machines. Older
> machines are the ones which have the OpenPROM version below 3.x and,
> therefore, are prone to the infamous 1 GB magic boundary bug. The PROM
> version is extracted from /proc/cpuinfo. If either of the checks fail,
> a message is displayed, explaining the situation and giving user a
> chance to go back to partitioning.
>
> The patch is against today's SVN version of partman-target, which
> seemed like a right place to put it in (it contains some generic checks
> already). I've run quite a few tests with it on both my machines and it
> handled correctly all the situations I could throw at it. Hopefully, it
> will be found worthy of committing.
>
> Best regards,
>
> Jurij Smakov                                        jurij@wooyd.org
> Key: http://www.wooyd.org/pgpkey/                   KeyID: C99E03CC


--Boundary-00=_MOLxBlu7z2EojOz
Content-Type: text/x-diff;
  charset="iso-8859-1";
  name="silo_check.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="silo_check.diff"

diff -aurN -x .svn partman-target_orig/debian/templates partman-target/debian/templates
--- partman-target_orig/debian/templates	2004-12-18 15:59:12.000000000 -0500
+++ partman-target/debian/templates	2004-12-18 16:03:26.000000000 -0500
@@ -88,3 +88,26 @@
 Type: text
 _Description: Help on partitioning
 
+Template: partman-target/silo_bad_fs
+Type: note
+_Description: Warning: unsupported boot filesystem type!
+ In order to be successfully loaded by SILO (Sparc Linux Loader), the
+ kernel must reside on an ext2, ext3 or ufs formatted partition. In
+ the current partitioning scheme the kernel is going to be installed
+ on the ${SILO_PART} partition of type ${SILO_TYPE}. It is strongly
+ recommended that you go back to partitioning and correct this
+ problem. Keeping the current configuration may result in an
+ unbootable system.
+
+Template: partman-target/silo_too_far
+Type: note
+_Description: Warning: boot partition may cause problems with SILO!
+ This machine is likely to suffer from a firmware bug, which makes it
+ impossible for SILO (Sparc Linux Loader) to boot a kernel placed
+ farther than 1 GB from the beginning of the disk. To avoid problems
+ it is strongly recommended to install the kernel into a partition
+ which fits entirely within the first GB of the disk (by creating a
+ small /boot partition in the beginning of the disk, for example). In
+ the current partitioning scheme it is going to be installed onto the
+ ${SILO_PART} partition which extends up to ${SILO_OFF} mark. Keeping
+ this configuration may result in an unbootable system.
diff -aurN -x .svn partman-target_orig/finish.d/_numbers partman-target/finish.d/_numbers
--- partman-target_orig/finish.d/_numbers	2004-12-18 15:59:12.000000000 -0500
+++ partman-target/finish.d/_numbers	2004-12-18 16:03:38.000000000 -0500
@@ -1,4 +1,5 @@
 05 proper_mountpoints
+06 silo_check
 20 mount_partitions
 39 create_fstab_header
 40 fstab_hd_entries
diff -aurN -x .svn partman-target_orig/finish.d/silo_check partman-target/finish.d/silo_check
--- partman-target_orig/finish.d/silo_check	1969-12-31 19:00:00.000000000 -0500
+++ partman-target/finish.d/silo_check	2004-12-18 16:05:38.000000000 -0500
@@ -0,0 +1,80 @@
+#!/bin/sh
+#
+# SILO can only boot from ext[23] or ufs filesystem. Also, if the old
+# PROM version is used (major version <= 2), the complete partition where
+# kernel is installed must fit within 1GB from the beginning of the disk.
+#
+# -- Jurij Smakov <jurij@wooyd.org>  Sat, 18 Dec 2004 16:05:16 -0500
+
+. /lib/partman/definitions.sh
+
+check_sparc()
+{
+  arch=$(archdetect 2>/dev/null) || exit 0
+  cpu="${arch%%/*}"
+  [ "${cpu}" = "sparc" ] || exit 0
+}
+  
+prom_major_version()
+{
+  [ -f /proc/cpuinfo ] || exit 0
+  prom="$(grep '^prom' /proc/cpuinfo | grep -v '^promlib')"
+  prom_version="${prom##*: }"
+  prom_major="${prom_version%%.*}"
+  echo "prom_major=${prom_major}"
+}
+
+boot_part_params()
+{
+  result=''
+  startdir="$(pwd)"
+  for dev in $DEVICES/*; do
+    [ -d "$dev" ] || continue
+    cd $dev
+    partitions=''
+    open_dialog PARTITIONS
+    while { read_line num id size type fs path name; [ "$id" ]; }; do
+	[ -f "${id}/mountpoint" ] || continue
+	mp=$(cat ${id}/mountpoint)
+	[ "${mp}" = /boot ] && \
+          result="boot_name=${mp} boot_fs=${fs} boot_last=${id##*-}"
+	[ "${mp}" = / ] && [ -z "${result}" ] && \
+          result="boot_name=${mp} boot_fs=${fs} boot_last=${id##*-}"
+    done
+    close_dialog
+done
+cd "${startdir}"
+echo "${result}"
+}
+
+silo_limit_check()
+{
+  if ! longint_le "${boot_last}" 1073741824 ; then
+      db_subst partman-target/silo_too_far SILO_PART "${boot_name}"
+      db_subst partman-target/silo_too_far SILO_OFF "$(longint2human ${boot_last})"
+      db_input critical partman-target/silo_too_far || true
+      db_go || exit 1
+  fi
+}
+
+silo_boot_fs_check()
+{
+  case "${boot_fs}" in
+      ext2|ext3|ufs)
+	  ;;
+      *)
+	  db_subst partman-target/silo_bad_fs SILO_PART "${boot_name}"
+	  db_subst partman-target/silo_bad_fs SILO_TYPE "${boot_fs}"
+	  db_input critical partman-target/silo_bad_fs || true
+	  db_go || exit 1
+	  ;;
+  esac
+}
+
+check_sparc
+eval "$(boot_part_params)"
+silo_boot_fs_check
+eval "$(prom_major_version)"
+[ -n "${prom_major}" ] || exit 0
+[ "${prom_major}" -le 2 ] || exit 0
+silo_limit_check

--Boundary-00=_MOLxBlu7z2EojOz--

---------------------------------------
Received: (at 286265-close) by bugs.debian.org; 11 Jan 2006 22:46:34 +0000
>From katie@ftp-master.debian.org Wed Jan 11 14:46:34 2006
Return-path: <katie@ftp-master.debian.org>
Received: from katie by spohr.debian.org with local (Exim 4.50)
	id 1EwoYu-0000ui-TB; Wed, 11 Jan 2006 14:35:24 -0800
From: Frans Pop <fjp@debian.org>
To: 286265-close@bugs.debian.org
X-Katie: $Revision: 1.65 $
Subject: Bug#286265: fixed in silo-installer 1.02
Message-Id: <E1EwoYu-0000ui-TB@spohr.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 11 Jan 2006 14:35:24 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level: 
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

Source: silo-installer
Source-Version: 1.02

We believe that the bug you reported is fixed in the latest version of
silo-installer, which is due to be installed in the Debian FTP archive:

silo-installer_1.02.dsc
  to pool/main/s/silo-installer/silo-installer_1.02.dsc
silo-installer_1.02.tar.gz
  to pool/main/s/silo-installer/silo-installer_1.02.tar.gz
silo-installer_1.02_sparc.udeb
  to pool/main/s/silo-installer/silo-installer_1.02_sparc.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 286265@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated silo-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Thu, 12 Jan 2006 01:07:00 +0100
Source: silo-installer
Binary: silo-installer
Architecture: source sparc
Version: 1.02
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description: 
 silo-installer - install silo on a hard disk (udeb)
Closes: 286265
Changes: 
 silo-installer (1.02) unstable; urgency=low
 .
   [ Joey Hess ]
   * Apply patch from Jurij Smakov to improve silo checks in partman.
     Closes: #286265.
 .
   [ Christian Perrier ]
   * Rewrite the warning note short description for general consistency
     with d-i writing style.
   * Remove an extra space at the end of a line in the templates file
     Thanks to Jens Seidel for noticing.
 .
   [ Colin Watson ]
   * Change "new Debian boot partition" to "new boot partition", to reduce
     branding problems for derivatives.
 .
   [ Frans Pop ]
   * Add myself to uploaders.
 .
   [ Updated translations ]
   * Arabic (ar.po) by Ossama M. Khayat
   * Bulgarian (bg.po) by Ognyan Kulev
   * Bengali (bn.po) by Baishampayan Ghose
   * Catalan (ca.po) by Guillem Jover
   * Czech (cs.po) by Miroslav Kure
   * Danish (da.po) by Claus Hindsgaul
   * German (de.po) by Jens Seidel
   * Greek (el.po) by quad-nrg.net
   * Spanish (es.po) by Javier Fernández-Sanguino Peña
   * Basque (eu.po) by Piarres Beobide
   * Persian (fa.po) by Arash Bijanzadeh
   * Finnish (fi.po) by Tapio Lehtonen
   * French (fr.po) by Christian Perrier
   * Galician (gl.po) by Jacobo Tarrio
   * Indonesian (id.po) by Parlin Imanuel Toh
   * Icelandic (is.po) by David Steinn Geirsson
   * Italian (it.po) by Giuseppe Sacco
   * Japanese (ja.po) by Kenshi Muto
   * Korean (ko.po) by Sunjae park
   * Kurdish (ku.po) by Erdal Ronahi
   * Lithuanian (lt.po) by KÄ?stutis BiliÅ«nas
   * Latvian (lv.po) by Aigars Mahinovs
   * Malagazy (mg.po) by Jaonary Rabarisoa
   * Macedonian (mk.po) by Georgi Stanojevski
   * Norwegian (nb.po) by Bjørn Steensrud
   * Dutch (nl.po) by Frans Pop
   * Norwegian (nn.po)
   * Polish (pl.po) by Bartosz Fenski
   * Portuguese (Brazil) (pt_BR.po) by André Luís Lopes
   * Portuguese (pt.po) by Miguel Figueiredo
   * Romanian (ro.po) by Eddy PetriÅ?or
   * Russian (ru.po) by Yuri Kozlov
   * Slovak (sk.po) by Peter Mann
   * Slovenian (sl.po) by Jure Ä?uhalev
   * Swedish (sv.po) by Daniel Nylander
   * Tagalog (tl.po) by Eric Pareja
   * Turkish (tr.po) by Recai OktaÅ?
   * Ukrainian (uk.po) by Eugeniy Meshcheryakov
   * Vietnamese (vi.po) by Clytie Siddall
   * Wolof (wo.po) by Mouhamadou Mamoune Mbacke
   * Simplified Chinese (zh_CN.po) by Ming Hua
   * Traditional Chinese (zh_TW.po) by Tetralet
Files: 
 98f17db6e9bb9dba53d23659d681b40a 672 debian-installer standard silo-installer_1.02.dsc
 db4854ddfee078a7ced578d70eec7cca 58371 debian-installer standard silo-installer_1.02.tar.gz
 ac47970fd897d8b10d4951075e38e671 39992 debian-installer standard silo-installer_1.02_sparc.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFDxXlHgm/Kwh6ICoQRAtVZAKCgJ2JivvAPEnI1PBsdll9tWRA1owCfWELF
YEoS+FY3waiy9Wrq+5isZOk=
=GlFk
-----END PGP SIGNATURE-----



Reply to: