[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#341054: Patch proposal

On Sat, Dec 31, 2005 at 12:30:47PM +0100, Attilio Fiandrotti wrote:
> I've just modified the GTK frontend so that if rescue/enable is true 
> then rescue/info is displayed in the top-left corner of the window, over 
>  the "Debian" banner.

No! Please, please don't hack names of other udebs' questions into
cdebconf like that. cdebconf has no business knowing about any question
names other than those that are part of its own internals (i.e.
debconf/*). Any time it does this, it will break when those question
names are changed at some later point for whatever reason.

rescue-check already sends an INFO command to cdebconf so that it
doesn't need to hardcode anything at all. Just look at obj->info instead
when you're displaying the screen; see the newt frontend, which checks
obj->info in newt_go() and newt_progress_start() and draws it on the
root window if obj->info is non-NULL and has a non-NULL description.


Colin Watson                                       [cjwatson@debian.org]

Reply to: