Bug#327698: marked as done (mklibs: Fails if symbols are provided by libs in ./usr/lib)
Your message dated Sat, 22 Oct 2005 13:33:54 -0700
with message-id <E1ETQ3u-0002gZ-00@spohr.debian.org>
and subject line Bug#327698: fixed in mklibs 0.1.18
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Sep 2005 15:52:41 +0000
>From aragorn@tiscali.nl Sun Sep 11 08:52:41 2005
Return-path: <aragorn@tiscali.nl>
Received: from vs5-deb.fnb.maschinenbau.tu-darmstadt.de (frost.pumuki.org) [130.83.174.41] (foobar)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EEU8H-0008Jr-00; Sun, 11 Sep 2005 08:52:41 -0700
Received: from [10.0.0.252] (unknown [10.0.0.252])
by frost.pumuki.org (Postfix) with ESMTP id EB1462EA922
for <submit@bugs.debian.org>; Sun, 11 Sep 2005 18:52:29 +0300 (EEST)
From: Frans Pop <aragorn@tiscali.nl>
To: submit@bugs.debian.org
Subject: mklibs: Fails if symbols are provided by libs in ./usr/lib
Date: Sun, 11 Sep 2005 17:53:11 +0200
User-Agent: KMail/1.7.2
MIME-Version: 1.0
Content-Type: multipart/signed;
boundary="nextPart1216540.lkAZBqVPdk";
protocol="application/pgp-signature";
micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200509111753.11517.aragorn@tiscali.nl>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no
version=2.60-bugs.debian.org_2005_01_02
--nextPart1216540.lkAZBqVPdk
Content-Type: multipart/mixed;
boundary="Boundary-01=_nLFJDG9loKilWhC"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
--Boundary-01=_nLFJDG9loKilWhC
Content-Type: text/plain;
charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Package: mklibs
Version: 0.1.16
Severity: important
Tags: d-i, patch
In debian-installer we currently have a build failure for s/390 because a=20
symbol that is provided by a library in ./usr/lib under the root is said=20
to be missing by mklibs in its final iteration even though it is actually=20
available. During the iterations the lib is "skipped" with a message "no=20
action required".
The attached patch will fix the issue by taking into account the symbols=20
provided by such libs when determining which symbols are already provided=20
and which are not during the reduction iterations.
It might be cleaner to process these libs in the same way as libs in=20
$TEMP/lib, but this patch seems the less invasive solution.
I intend to NMU this patch tomorrow unless someone objects.
--Boundary-01=_nLFJDG9loKilWhC
Content-Type: text/x-diff;
charset="us-ascii";
name="mklibs.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: attachment;
filename="mklibs.patch"
=2D-- mklibs-0.1.16.orig/mklibs.py 2005-09-11 17:46:29.137061276 +0200
+++ mklibs-0.1.16/mklibs.py 2005-09-11 17:46:55.934219847 +0200
@@ -368,6 +368,7 @@
lib_path.extend(lib_rpath)
=20
passnr =3D 1
+available_libs =3D []
previous_pass_unresolved =3D Set()
while 1:
debug(DEBUG_NORMAL, "I: library reduction pass", `passnr`)
@@ -407,9 +408,11 @@
# doesn't hurt. I guess all archs can live with this.
needed_symbols.add(("sys_siglist", 1))
=20
=2D # calculate what symbols are present in small_libs
+ # calculate what symbols are present in small_libs and available_libs
present_symbols =3D Set()
=2D for lib in small_libs:
+ checked_libs =3D small_libs
+ checked_libs.extend(available_libs)
+ for lib in checked_libs:
present_symbols.merge(provided_symbols(lib))
=20
# are we finished?
@@ -479,6 +482,9 @@
so_file =3D find_lib(library)
if root and (re.compile("^" + root).search(so_file)):
debug(DEBUG_VERBOSE, "no action required for " + so_file)
+ if not so_file in available_libs:
+ debug(DEBUG_VERBOSE, "adding " + so_file + " to available =
libs")
+ available_libs.append(so_file)
continue
so_file_name =3D os.path.basename(so_file)
if not so_file:
--Boundary-01=_nLFJDG9loKilWhC--
--nextPart1216540.lkAZBqVPdk
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQBDJFLngm/Kwh6ICoQRAmSLAJ0SvtaAadspO+MaJfAlo4m6IrqbugCdH/b6
DNCQNU7tBu0PYfs6MZ47HCU=
=6xBW
-----END PGP SIGNATURE-----
--nextPart1216540.lkAZBqVPdk--
---------------------------------------
Received: (at 327698-close) by bugs.debian.org; 22 Oct 2005 20:40:28 +0000
>From katie@spohr.debian.org Sat Oct 22 13:40:28 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1ETQ3u-0002gZ-00; Sat, 22 Oct 2005 13:33:54 -0700
From: Frans Pop <fjp@debian.org>
To: 327698-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#327698: fixed in mklibs 0.1.18
Message-Id: <E1ETQ3u-0002gZ-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sat, 22 Oct 2005 13:33:54 -0700
Delivered-To: 327698-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2
Source: mklibs
Source-Version: 0.1.18
We believe that the bug you reported is fixed in the latest version of
mklibs, which is due to be installed in the Debian FTP archive:
mklibs-copy_0.1.18_i386.deb
to pool/main/m/mklibs/mklibs-copy_0.1.18_i386.deb
mklibs_0.1.18.dsc
to pool/main/m/mklibs/mklibs_0.1.18.dsc
mklibs_0.1.18.tar.gz
to pool/main/m/mklibs/mklibs_0.1.18.tar.gz
mklibs_0.1.18_all.deb
to pool/main/m/mklibs/mklibs_0.1.18_all.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 327698@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frans Pop <fjp@debian.org> (supplier of updated mklibs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 22 Oct 2005 21:21:18 +0200
Source: mklibs
Binary: mklibs mklibs-copy
Architecture: source all i386
Version: 0.1.18
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Frans Pop <fjp@debian.org>
Description:
mklibs - Shared library reduction script
mklibs-copy - Shared library reduction script
Closes: 33277 327698 334544
Changes:
mklibs (0.1.18) unstable; urgency=low
.
* Do not include rpaths multiple times (closes: #334544).
* Add debugging output when adding undefined symbols (closes: #33277).
* Add myself to uploaders.
* Acknowlegde NMU (closes: #327698).
Files:
eb1590f7dc9c6b81a8d906fbc45d5e4e 697 devel optional mklibs_0.1.18.dsc
bd90cf9cba96650557430a8ba2f0bce4 104447 devel optional mklibs_0.1.18.tar.gz
5acfe0122906939095ad0a4463d45fe9 31104 devel optional mklibs-copy_0.1.18_i386.deb
665746cb0f08c929014c090d6614b231 11156 devel optional mklibs_0.1.18_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDWpURgm/Kwh6ICoQRAmYNAJ9X4UP2ngQwuYjNKssJiNoEyGyVtACgr2pt
6EwDd0qtisAd60ORwQGTDVY=
=Be+U
-----END PGP SIGNATURE-----
Reply to: