[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#324495: Strange screen during French install



tags 324495 + patch
thanks

12 жовтня 2005 о 06:47 +0200 Christian Perrier написав(-ла):
> Quoting Frans Pop (aragorn@tiscali.nl):
> > On Tuesday 11 October 2005 22:15, Christian Perrier wrote:
> > > Actually, this is a problem I've already seen: dialog boxes are not
> > > sized accordingly to buttons width, but only according to the text
> > > inside the dialog box.
> > 
> > Looks like the title is truncated too.
> 
> Yes, that happens also. Neither titles, nor buttons are taken into
> account for screen width calculations.
Actually both are take into account but: only one button for this type
of question, and only width of title text (without '[!] ' & co).

> 
> Eugenyi, I highly suspect this to pertain to newt....Could you
> confirm?
No I cannot confirm. It is bug in cdebconf. Attached patch fixes this
for buttons. To fix this also for header it is probably required to do
s/get_text_width(obj->title)/get_text_width(obj->title) + <some_value>/
in modules/frontend/newt/newt.c . On screenshot there are 5 symbols
missing and there is "[!] " prefix that is 4 symbols log. Longest
possible prefix is "[!!] " so i think <some_value> should be 6.

-- 
Eugeniy Meshcheryakov

Kyiv National Taras Shevchenko University
Information and Computing Centre
http://icc.univ.kiev.ua
Index: src/modules/frontend/newt/newt.c
===================================================================
--- src/modules/frontend/newt/newt.c	(revision 31337)
+++ src/modules/frontend/newt/newt.c	(working copy)
@@ -413,7 +413,7 @@
     }
     t_height = win_height - 6;
     t_width = get_text_width(full_description);
-    t_width_buttons = 2*BUTTON_PADDING;
+    t_width_buttons = 2*BUTTON_PADDING + get_text_width(continue_text(obj)) + 2;
     if (obj->methods.can_go_back(obj, q))
         //  Add an interspace
         t_width_buttons += get_text_width(goback_text(obj)) + 3;

Attachment: signature.asc
Description: Digital signature


Reply to: