[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: PATCH: fix ramdisk_size parameter for hppa



On Tue, Sep 20, 2005 at 10:17:38PM +0200, Geert Stappers wrote:
> On Tue, Sep 20, 2005 at 03:56:52PM +0100, Richard Hirst wrote:
> > This is a patch for debian-cd, which currently invokes palo with
> > a hardcoded value of 16384K.  We currently need about 21M.
> > The patch calculates the correct value at ISO build time.
> > 
> > Could someone with access submit this to svn for me please?
> 
> If it stays calm here, then please post to the Debian CD mailinglist.

ok

> > 
> > I have built and booted an ISO with this patch.
> > 
> > Thanks
> >   Richard
> > 
> 
> > Index: tools/boot/etch/post-boot-hppa
> > ===================================================================
> > --- tools/boot/etch/post-boot-hppa	(revision 935)
> > +++ tools/boot/etch/post-boot-hppa	(working copy)
> > @@ -23,8 +23,9 @@
> >  
> >  K32=$(ls $CDROOT/install/vmlinux-*-32|head -1)
> >  K64=$(ls $CDROOT/install/vmlinux-*-64|head -1)
> > +RSIZE=$(expr $(zcat "$CDROOT/install/initrd.gz" | wc --bytes) / 1024)
> >  /sbin/palo \
> > -     --commandline="0/vmlinux root=/dev/ram initrd=0/ramdisk ramdisk_size=16384 init=/linuxrc" \
> > +     --commandline="0/vmlinux root=/dev/ram initrd=0/ramdisk ramdisk_size=$RSIZE init=/linuxrc" \
> >       --recoverykernel="$K32" \
> >       --recoverykernel="$K64" \
> >       --bootloader="$CDROOT/install/iplboot" \
> 
> Cool concept.
> 
> I think it needs a minor addition.
> 
> | $ expr 2000 / 1024
> | 1
> | $ expr 2000 / 1024 + 1
> | 2
> 
> 
>   -RSIZE=$(expr $(zcat "$CDROOT/install/initrd.gz" | wc --bytes) / 1024)
>   +RSIZE=$(expr $(zcat "$CDROOT/install/initrd.gz" | wc --bytes) / 1024 + 1 )

I took the expr line from d-i code, installer/build/util/ramdisk-size-subst,
which has the comment:

# expr's round down is ok, I think; ext2 disks are a multiple of 1024 bytes

which sounded reasonable to me, so I didn't do the "+1".

> 
> > Index: debian/changelog
> > ===================================================================
> > --- debian/changelog	(revision 935)
> > +++ debian/changelog	(working copy)
> > @@ -1,5 +1,8 @@
> >  debian-cd (2.2.24) UNRELEASED; urgency=low
> >  
> > +  [ Richard Hirst ]
> > +    - Fix ramdisk_size value for hppa
> > +
> >    [ Frans Pop ]
> >      - Update for Sparc:
> >        - sparc64: switch to 2.6.12 kernel; make CD multiboot 2.6 and 2.4,
> 
> 
> Geert Stappers
> Has on his long wishlist: Reproducing Richard Hirst's work on VME147
> ( in other words: a fan of your work )

:-) Thanks ... havn't touched my 147 in a long time!

Richard


> 
> 
> -- 
> To UNSUBSCRIBE, email to debian-boot-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org



Reply to: