[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#327892: marked as done (cdebconf-gtk-udeb: improved bidi support)

Your message dated Sat, 17 Sep 2005 10:02:04 -0700
with message-id <E1EGg4i-0006sR-00@spohr.debian.org>
and subject line Bug#327892: fixed in cdebconf 0.85
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 12 Sep 2005 19:41:02 +0000
>From eugen@univ.kiev.ua Mon Sep 12 12:41:02 2005
Return-path: <eugen@univ.kiev.ua>
Received: from univ-gw.univ.kiev.ua (relay.univ.kiev.ua) [] 
	by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
	id 1EEuAo-00088t-00; Mon, 12 Sep 2005 12:41:02 -0700
Received: from [] (helo=intel4.icc.univ.kiev.ua)
	by relay.univ.kiev.ua with esmtp (Exim 4.41 (FreeBSD))
	id 1EEuCx-000KlK-H4; Mon, 12 Sep 2005 22:43:15 +0300
Received: from eugen by intel4.icc.univ.kiev.ua with local (Exim 4.52)
	id 1EEuAb-0000m4-Bg; Mon, 12 Sep 2005 22:40:49 +0300
Content-Type: multipart/mixed; boundary="===============1038286160=="
MIME-Version: 1.0
From: Eugeniy Meshcheryakov <eugen@univ.kiev.ua>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: cdebconf-gtk-udeb: improved bidi support
X-Mailer: reportbug 3.17
Date: Mon, 12 Sep 2005 22:40:49 +0300
Message-Id: <[🔎] E1EEuAb-0000m4-Bg@intel4.icc.univ.kiev.ua>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02

This is a multi-part MIME message sent by reportbug.

Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: cdebconf-gtk-udeb
Severity: normal
Tags: patch l10n

Attached patch allows to change default text direction depending on
current language (without patch it is only possible in installed system and
not in d-i because of use of gettext). Thi patch adds one more template
to translate (debconf/text-direction). It should be translated to RTL or
LTR depending on default text direction for language (translations are
not included in this patch).

Here is a screenshot for Hebrew that shows effect of this patch:

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13
Locale: LANG=uk_UA.UTF-8, LC_CTYPE=uk_UA.UTF-8 (charmap=UTF-8)

Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="cdebconf-gtk+bidi.diff"

Index: debian/cdebconf-gtk-udeb.templates
--- debian/cdebconf-gtk-udeb.templates	(revision 30510)
+++ debian/cdebconf-gtk-udeb.templates	(working copy)
@@ -13,3 +13,9 @@
 Template: debconf/button-no
 Type: text
 _Description: No
+Template: debconf/text-direction
+Type: text
+# This should be translated to RTL or LTR depending of default text
+# direction of given language
+_Description: LTR
Index: src/modules/frontend/gtk/gtk.c
--- src/modules/frontend/gtk/gtk.c	(revision 30510)
+++ src/modules/frontend/gtk/gtk.c	(working copy)
@@ -574,15 +574,21 @@
 return TRUE;
-#if 0 /* currently unused */
 static const char *
 get_text(struct frontend *obj, const char *template, const char *fallback )
     struct question *q = obj->qdb->methods.get(obj->qdb, template);
     return q ? q_get_description(q) : fallback;
+static GtkTextDirection get_text_direction(struct frontend *obj)
+	const char *dirstr = get_text(obj, "debconf/text-direction", "LTR - default text direction");
+	if (dirstr[0] == 'R')
+		return GTK_TEXT_DIR_RTL;
+	return GTK_TEXT_DIR_LTR;
 gboolean need_continue_button(struct frontend *obj)
     if (obj->questions->next == NULL)
@@ -1490,7 +1496,9 @@
         gtk_widget_set_sensitive (data->button_prev, FALSE);
     gtk_widget_set_sensitive(GTK_WIDGET(data->button_next), TRUE);
+    gtk_widget_set_default_direction(get_text_direction(obj));


Received: (at 327892-close) by bugs.debian.org; 17 Sep 2005 17:09:03 +0000
>From katie@spohr.debian.org Sat Sep 17 10:09:03 2005
Return-path: <katie@spohr.debian.org>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
	id 1EGg4i-0006sR-00; Sat, 17 Sep 2005 10:02:04 -0700
From: Colin Watson <cjwatson@debian.org>
To: 327892-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#327892: fixed in cdebconf 0.85
Message-Id: <E1EGg4i-0006sR-00@spohr.debian.org>
Sender: Archive Administrator <katie@spohr.debian.org>
Date: Sat, 17 Sep 2005 10:02:04 -0700
Delivered-To: 327892-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 2

Source: cdebconf
Source-Version: 0.85

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdebconf/cdebconf-gtk-udeb_0.85_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.85_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.85_all.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.85_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.85_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf_0.85.dsc
  to pool/main/c/cdebconf/cdebconf_0.85.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.85_powerpc.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.85_powerpc.deb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.85_powerpc.udeb
  to pool/main/c/cdebconf/libdebconfclient0_0.85_powerpc.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 327892@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Colin Watson <cjwatson@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Sat, 17 Sep 2005 17:37:18 +0100
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source powerpc all
Version: 0.85
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-gtk-udeb - Gtk+ frontend for Debian Configuration Management System (udeb)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 322461 327892
 cdebconf (0.85) unstable; urgency=low
   [ Colin Watson ]
   * Initialise all fields of the gtk frontend data. Should fix several
   * Don't crash if display_dummy_main_menu() is called while we don't have a
     main-menu tag, e.g. if a progress bar is started before asking any
     questions at high priority. This is just a hack; Attilio needs to
     investigate the right solution. Reducing the amount of hardcoding of
     main-menu would be nice ...
   * Don't bother to save the target templatedb in debconf-copydb unless any
     templates were actually changed.
   * Make debconf-loadtemplate check whether each question is registered to
     some different template and, if so, re-register them to the loaded
     template. This causes preseeded-as-seen questions to be displayed using
     their real templates rather than debian-installer/dummy.
   [ Tollef Fog Heen ]
   * When copying questions in debconf-copydb, make sure that the template
     referred to exists in the target database.
   [ Attilio Fiandrotti ]
   * Better and more flexible questionbox widget packing system.
   * The main-menu hack can now be disabled at compile time.
   * Committed a patch by Eugeniy Meshcheryakov to the GTK frontend to
     properly display RTL-written languages (closes: #327892).
   * Back and Forward buttons are now localized (closes: #322461).
 6c36297b28ac55ca8a353c1a94dbc8e4 1117 utils optional cdebconf_0.85.dsc
 06ea0e6e0efa6a8922064daf264772fd 213408 utils optional cdebconf_0.85.tar.gz
 f5873cf7984ac7f2183f3e8b985f577c 2266 debian-installer standard cdebconf-priority_0.85_all.udeb
 f07979eb506795d16f2fc1e13e9cf65e 151226 utils extra cdebconf_0.85_powerpc.deb
 1d9fa1906779e12ab60e71878a0a4421 27094 libs optional libdebconfclient0_0.85_powerpc.deb
 030c909359e5be18dc863119bb2f580b 24266 libdevel optional libdebconfclient0-dev_0.85_powerpc.deb
 3856ac6c19cc6427644da0a0b0062a7d 75518 debian-installer standard cdebconf-udeb_0.85_powerpc.udeb
 2f5b4da7569d2ca9d1b9122d44401eb9 4852 debian-installer optional libdebconfclient0-udeb_0.85_powerpc.udeb
 b9b9ea02aaf1b076add34ac56c4fce27 14706 debian-installer optional cdebconf-newt-udeb_0.85_powerpc.udeb
 651aece965c5cead739fe052d884cd25 18256 debian-installer optional cdebconf-text-udeb_0.85_powerpc.udeb
 a3c88ef1ba75e79adfb8ee53b71c84e4 16970 debian-installer optional cdebconf-gtk-udeb_0.85_powerpc.udeb
Package-Type: udeb

Version: GnuPG v1.4.1 (GNU/Linux)


Reply to: