[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#327103: partman-* scripts all missing set -e



Package: partman-base
Version: 71

Pretty much none of the partman shell scripts say set -e:

-anarres:work> find partman-* -type f | xargs egrep -l '^#! ?/bin/sh$' | xargs egrep -L 'set -e' | wc -l
151
-anarres:work> find partman-* -type f | xargs egrep -l '^#! ?/bin/sh' | xargs egrep -l ' -e' | wc -l 
24

Note that this is not a 100% reliable way to find broken scripts.
Some of these are one-liners and so don't need it.  Others will use
command || othercommand _every_ time.  Others will say ` -e' as an
option to some other command.

I think the only sensible thing to do is to perl -i every `#!/bin/sh'
line in every partman package to `#!/bin/sh -e' and then eyeball the
results.

*sigh* !

Ian.



Reply to: