[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#323804: bad behavior is arch_get_kernel_flavour returns nonzero



Package: base-installer
Severity: normal
Tags: d-i

On arm, arch_get_kernel_flavour can return nonzero on many subarches
that d-i does not have explcit support for. This actually crashes
base-installer back to the menu with no indication what was wrong.

Sarge's base-installer instead went on and installed some random kernel,
which is really better behavior, though not ideal. At least the install
succeeds and someone trying to install Debian on an odd arm subarch can
try to provide their own kernel.

Here is one way to fix it:

-FLAVOUR="$(arch_get_kernel_flavour)"
+FLAVOUR="$(arch_get_kernel_flavour)" || true

But I don't know if that's the best way. It will result in FLAVOUR not
being set, so the call to arch_check_usable_kernel will succeed (on arm
at least) for every kernel, and it will go back to the sarge behavior of
installing a random kernel. Also I'm not sure if we should just ignore
that exit code as it's documented as something arch_get_kernel_flavour
can return in this case.

It might be better to do something like catch the nonzero exit and
display base-installer/kernel/no-kernels-found and continue on without
installing a kernel.

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.4.27
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: