Bug#308964: marked as done (Preseeding .1 host IP bug)
Your message dated Mon, 27 Jun 2005 00:32:15 -0400
with message-id <E1DmlI7-0006kb-00@newraff.debian.org>
and subject line Bug#308964: fixed in netcfg 1.12
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 13 May 2005 14:12:58 +0000
>From mike@zen.co.uk Fri May 13 07:12:58 2005
Return-path: <mike@zen.co.uk>
Received: from pythagoras.zen.co.uk [212.23.3.140]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DWauP-0006L6-00; Fri, 13 May 2005 07:12:57 -0700
Received: from [212.23.9.201] (helo=localhost.localdomain)
by pythagoras.zen.co.uk with esmtp (Exim 4.30)
id 1DWauO-0007C3-80
for submit@bugs.debian.org; Fri, 13 May 2005 14:12:56 +0000
Subject: Preseeding .1 host IP bug
From: Michael Dorrington <mike@zen.co.uk>
To: submit@bugs.debian.org
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.5
Date: 13 May 2005 15:12:56 +0100
Message-Id: <1115993576.14691.78.camel@gluon.office.zen.co.uk>
Mime-Version: 1.0
X-Originating-Pythagoras-IP: [212.23.9.201]
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: installation-reports
INSTALL REPORT
Debian-installer-version: RC3 boot.img.gz, 20050505 sarge-i386-netinst.iso
uname -a: N/A
Date: 13th May 2005
Method: hd-media install + preseed file.
Machine: N/A
Processor: N/A
Memory: N/A
Root Device: N/A
Root Size/partition table: N/A
Output of lspci and lspci -n: N/A
Base System Installation Checklist:
[O] = OK, [E] = Error (please elaborate below), [ ] = didn't try it
Initial boot worked: [0]
Configure network HW: [0]
Config network: [E]
Detect CD: [ ]
Load installer modules: [ ]
Detect hard drives: [ ]
Partition hard drives: [ ]
Create file systems: [ ]
Mount partitions: [ ]
Install base system: [ ]
Install boot loader: [ ]
Reboot: [ ]
Comments/Problems:
There is a bug in the installer (netcfg?) that gives a Red Screen of Death
(RSoD) if you preseed with a host IP address of x.x.x.1.
If you manually enter one, instead of preseeding, the installer works fine.
RSoD is:
[!!] Configure the network
Malformed IP address
The IP address you provided is malformed. It should be in the form
x.x.x.x where each 'x' is no larger than 255. Please try again.
<Continue>
However, pressing enter just gives you the same screen straight back, you can
not proceed through the installer.
Example preseed that is successful (taken from example-preseed.txt):
d-i netcfg/disable_dhcp boolean true
d-i netcfg/get_nameservers string 192.168.1.1
d-i netcfg/get_ipaddress string 192.168.1.42
d-i netcfg/get_netmask string 255.255.255.0
d-i netcfg/get_gateway string 192.168.1.1
Example preseed that fails (swapped gateway/nameserver IP and host IP):
d-i netcfg/disable_dhcp boolean true
d-i netcfg/get_nameservers string 192.168.1.42
d-i netcfg/get_ipaddress string 192.168.1.1
d-i netcfg/get_netmask string 255.255.255.0
d-i netcfg/get_gateway string 192.168.1.42
If you manually enter a host IP address of 192.168.1.42 then the installer
pre-fills the gateway with 192.168.1.1, which you can then edit if you wish or
just accept it.
If you manually enter a host IP address of 192.168.1.1 then the installer
pre-fills the gateway with 192.168.1., which you then need to edit as that
isn't a valid IP.
This pre-filling of the gateway with x.x.x.1 is where I think the problem comes
from. Here is what I think is the relevant code, in packages/netcfg/static.c:
if (ipaddress.s_addr != old_ipaddress.s_addr ||
netmask.s_addr != old_netmask.s_addr)
{
network.s_addr = ipaddress.s_addr & netmask.s_addr;
broadcast.s_addr = (network.s_addr | ~netmask.s_addr);
/* Preseed gateway */
gateway.s_addr = ipaddress.s_addr & netmask.s_addr;
gateway.s_addr |= htonl(1);
}
inet_ntop (AF_INET, &gateway, ptr1, sizeof (ptr1));
/* if you entered a .1 ip, you'll get a .1 back, so makes sense
* to clear the last bit */
if (gateway.s_addr == ipaddress.s_addr)
{
char* ptr = strrchr(ptr1, '.');
assert (ptr); /* if there's no dot in ptr1 we're in deep shit */
ptr[1] = '\0';
}
Mike.
---------------------------------------
Received: (at 308964-close) by bugs.debian.org; 27 Jun 2005 04:38:04 +0000
>From katie@ftp-master.debian.org Sun Jun 26 21:38:04 2005
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DmlNk-00028S-00; Sun, 26 Jun 2005 21:38:04 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1DmlI7-0006kb-00; Mon, 27 Jun 2005 00:32:15 -0400
From: Joey Hess <joeyh@debian.org>
To: 308964-close@bugs.debian.org
X-Katie: $Revision: 1.56 $
Subject: Bug#308964: fixed in netcfg 1.12
Message-Id: <E1DmlI7-0006kb-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Mon, 27 Jun 2005 00:32:15 -0400
Delivered-To: 308964-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 3
Source: netcfg
Source-Version: 1.12
We believe that the bug you reported is fixed in the latest version of
netcfg, which is due to be installed in the Debian FTP archive:
netcfg-dhcp_1.12_i386.udeb
to pool/main/n/netcfg/netcfg-dhcp_1.12_i386.udeb
netcfg-static_1.12_i386.udeb
to pool/main/n/netcfg/netcfg-static_1.12_i386.udeb
netcfg_1.12.dsc
to pool/main/n/netcfg/netcfg_1.12.dsc
netcfg_1.12.tar.gz
to pool/main/n/netcfg/netcfg_1.12.tar.gz
netcfg_1.12_i386.udeb
to pool/main/n/netcfg/netcfg_1.12_i386.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 308964@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated netcfg package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 26 Jun 2005 11:46:23 -0400
Source: netcfg
Binary: netcfg-static netcfg-dhcp netcfg
Architecture: source i386
Version: 1.12
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description:
netcfg - Configure the network (udeb)
netcfg-dhcp - Configure the network via DHCP (udeb)
netcfg-static - Configure a static network (udeb)
Closes: 282650 285124 308964 314618 315030
Changes:
netcfg (1.12) unstable; urgency=low
.
[ Joey Hess ]
* Apply patch from Christian Weeks and Geert Stappers to respect preseeded
nameserver values. Closes: #315030
* Similar fix to respect preseeded gateway value. Closes: #314618, #308964
* Above also Closes: #282650
* Note that above changes do make netcfg not fill in calculated values if
the user re-does static network config a second time.
* Fix spelling of IBM's Hipersocket. Closes: #285124
* A few interface types seem to be pure product names and not translatable.
Do not mark these templates as translatable.
.
* Updated translations:
- Czech (cs.po) by Miroslav Kure
- French (fr.po) by Christian Perrier
- Italian (it.po) by Giuseppe Sacco
- Japanese (ja.po) by Kenshi Muto
- Portuguese (Brazil) (pt_BR.po) by André LuÃs Lopes
- Romanian (ro.po) by Eddy PetriÅ?or
- Slovak (sk.po) by Peter Mann
- Albanian (sq.po) by Elian Myftiu
Files:
b67fac6c6b3d8fb9547e30aaeea1ea04 886 debian-installer optional netcfg_1.12.dsc
e5963e5f1b26e47170d881b455f15fb8 191519 debian-installer optional netcfg_1.12.tar.gz
62fb62fb45aa3dda3a8542ec54b4461b 160708 debian-installer optional netcfg_1.12_i386.udeb
3818c5a0766570838fa5ac1a3499de12 126880 debian-installer optional netcfg-dhcp_1.12_i386.udeb
a02cebf0a3c74188bc258eb97e633a78 121362 debian-installer optional netcfg-static_1.12_i386.udeb
package-type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCv31S2tp5zXiKP0wRAtJkAJ46tY6XV8dvWhB1W+Ug1y6zr61g/gCfROp7
97QNwBl0Cx0HFVnhMYLQL/s=
=Ko+u
-----END PGP SIGNATURE-----
Reply to: