[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#314618: overwrites preseeded gateway with nonsense



Michael Ablassmeier wrote:
> im using preseed files to automatically install machines behind a
> loadbalancer where no dhcpd is running. Preseeding the Gateway 
> results in d-i setting crap:
> 
>  d-i    netcfg/get_gateway  string  19.224.8.230
> 
> will produce:
> 
>  ~ #: debconf-get netcfg/gateway
>  19.224.0.230
> 
> however, attached patch should fix this. 
> 
> bye,
>     - michael

> --- static.c.orig	2005-06-17 15:10:04.000000000 +0200
> +++ static.c	2005-06-17 15:10:22.000000000 +0200
> @@ -130,9 +130,9 @@
>        char* ptr = strrchr(ptr1, '.');
>        assert (ptr); /* if there's no dot in ptr1 we're in deep shit */
>        ptr[1] = '\0';
> -    }
>      
> -    debconf_set(client, "netcfg/get_gateway", ptr1);
> +      debconf_set(client, "netcfg/get_gateway", ptr1);
> +    }
>  
>      return 0;
>  }

Seems to me that this patch disables guessing of a gateway address
during interactive installs, except for the case where the system's IP
address ends in .1, when the special case you moved the variable set
into fires. I don't think that's a good idea.

We need some other fix. One would be to not set netcfg/get_gateway if it
already has a value, although along with supporting preseeding of it,
this would make it not be auto-cacluated if the user revisited the
netmask question in netcfg.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: