[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#267219: marked as done (Why just floppy, why not USB stick.)



Your message dated Tue, 17 May 2005 13:06:30 -0400
with message-id <E1DY5WY-0000os-00@newraff.debian.org>
and subject line Bug#267219: fixed in installation-report 2.0
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 21 Aug 2004 07:55:27 +0000
>From osamu@aokiconsulting.com Sat Aug 21 00:55:27 2004
Return-path: <osamu@aokiconsulting.com>
Received: from outmx013.isp.belgacom.be [195.238.3.64] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1ByQik-0005qa-00; Sat, 21 Aug 2004 00:55:26 -0700
Received: from outmx013.isp.belgacom.be (localhost [127.0.0.1])
        by outmx013.isp.belgacom.be (8.12.11/8.12.11/Skynet-OUT-2.22) with ESMTP id i7L7tO6o003651
        for <submit@bugs.debian.org>; Sat, 21 Aug 2004 09:55:24 +0200
        (envelope-from <osamu@aokiconsulting.com>)
Received: from dambo.lan.aokiconsulting.com (122.81-201-80.adsl.skynet.be [80.201.81.122])
        by outmx013.isp.belgacom.be (8.12.11/8.12.11/Skynet-OUT-2.22) with ESMTP id i7L7tMFQ003613
        for <submit@bugs.debian.org>; Sat, 21 Aug 2004 09:55:22 +0200
        (envelope-from <osamu@aokiconsulting.com>)
Received: from osamu by dambo.lan.aokiconsulting.com with local (Exim 4.34)
	id 1ByQpm-0002BM-ED
	for submit@bugs.debian.org; Sat, 21 Aug 2004 10:02:42 +0200
Date: Sat, 21 Aug 2004 10:02:42 +0200
From: Osamu Aoki <osamu@debian.org>
To: submit@bugs.debian.org
Subject: Why just floppy, why not USB stick.
Message-ID: <20040821080242.GA4173@aokiconsulting.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="i0/AhcQY5QxfSsSZ"
Content-Disposition: inline
X-GPG-Fingerprint: 253A 4076 6A3B CCE2 A426  DEF5 E80F C4C1 A806 1F32
User-Agent: Mutt/1.5.6+20040803i
Sender: Osamu Aoki <osamu@aokiconsulting.com>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-3.0 required=4.0 tests=BAYES_00 autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 


--i0/AhcQY5QxfSsSZ
Content-Type: multipart/mixed; boundary="NzB8fVQJ5HfG6fxh"
Content-Disposition: inline


--NzB8fVQJ5HfG6fxh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Package: bugreporter-udeb
Version: 0.27
Severity: wishlist
Tags: patch, d-i

Hi,

As you all know, there are more PC with USB port than one with floppy
drive these days. But, bugreporter-udeb try to save data in floppy. =20

As I start playing d-i, I realized pluging in empty vfat formatted USB
key before hw-detect was very convienient way to get log out.  I just
mount a scsi device which happen to be USB key.

THis can be done with any USB storage such as USB HDD.

Can we do the same for bugreporter-udeb?  I used init code from
rootskel/src-bootfloppy and updated bugreporter-udeb.postinst script (no
testing yet).  This will not only mount floppy but any USB key (or USB
storage) devices formatted with vfat partition and save log there.  Also
this now create new directory so old report will not be overwritte.

Code (untested) is short and attached.

Code review or your thought is appreciated.

This should address practical functional issues of "USB floppy not
detected" since you can plug in USB key to get data out. #220306, #221575

BTW, where the USB floppies show up?  These bugs may even be taken care
with the followng code for current code:

  find /dev/scsi -name 'part?'||true

(I am sure removing -name 'part?' will take care but makes less
efficient.)  Hmmm... this seem to really fix these bugs too.

Osamu

PS: I found minor efficiency bug in rootskel/src-bootfloppy

PPS: I guess I need to update Release file in CD too to get it working.
But what else is needed to replace udeb in netinst CD?  I need to test
this udeb.  Doing upkg -i bugreporter-udeb* from console while $PWD on
/cdrom/..../bugreporter-udeb* is sufficient?


--NzB8fVQJ5HfG6fxh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="bugreporter-udeb.postinst"
Content-Transfer-Encoding: quoted-printable

#!/bin/sh -e=20

=2E /usr/share/debconf/confmodule

log() {
    logger -t bugreporter-udeb -p user.debug "$@"
}

if [ "" =3D "$DILOGDIR" ]; then
    DILOGDIR=3D/var/log/
fi
# make sure we have a directory
if [ ! -d $DILOGDIR ]; then
	mkdir -p $DILOGDIR
fi

copy_cdebconf_db() {
    destdir=3D"$1"
    # Save database to disk
    # kill -? <pid-of-debconf>
    cp -a /var/lib/cdebconf "$destdir"
}

db_input critical bugreporter-udeb/insert_floppy || [ $? -eq 30 ]
db_go

# generate files with HW info, debconf database info etc, and store
# them in $DILOGDIR
db_progress START 0 3 debian-installer/bugreporter-udeb/title

/bin/package-versions > $DILOGDIR/package-versions
db_progress STEP 1

/bin/report-hw > $DILOGDIR/hardware-summary
db_progress STEP 1

# Mostly copied from rootskel/src-bootfloppy. [2004-08-20]
mountfloppy() {
    # Try mounting USB memory key
    if [ -x /usr/sbin/usb-discover ]; then
	/usr/sbin/usb-discover
    fi
    # This is currently needed or usb-storage won't load (for ide_fix_drive=
id).
    modprobe ide-core >/dev/null
    modprobe usb-storage >/dev/null
    modprobe sd_mod >/dev/null
    MOUNTED=3D0
    while [ "$MOUNTED" =3D 0 ]; do
	DEVS=3D""
	if [ -d /dev/floppy ]; then
	    # Should I keep /dev/floppy/?
	    DEVS=3D/dev/floppy/0
	fi
	# Assuming USB storage partition to be formated with vfat partition
	if [ -d /dev/scsi ]; then
	    DEVS=3D"$DEVS `find /dev/scsi -name 'part?'||true`"
	fi

	ERR=3D""
	for dev in $DEVS; do
	    if [ "$MOUNTED" =3D 0 ] && [ -b $dev ]; then
		# Use /floppy as mount point even if USB storage.
		if mount $dev -o rw -tvfat /floppy 2>/dev/null; then
		    MOUNTED=3D1
		else
		    ERR=3D"$ERR $dev: cannot mount"
		    umount /floppy 2>/dev/null || true
		fi
	    fi
	done

	if [ "$MOUNTED" =3D 0 ]; then
	    if [ -n "$ERR" ]; then
		# ERR begins with a semicolon
		log "Cannot find $ERR"
	    else
		log "No devices found!"
	    fi
	    exit 1
	fi
	log "Mounted floppy: $dev"
	return 0
}

test -d /floppy || mkdir /floppy
umount /floppy 2>/dev/null || true

if mountfloppy ; then
    log "Floppy or USB storage mounted on /floppy"
    # Since USB key is big, let's try to many several install logs there.
    for i in
            00 01 02 03 04 05 06 07 08 09 \
            10 11 12 13 14 15 16 17 18 19 \
            20 21 22 23 24 25 26 27 28 29 END ; do
	LOGDIR=3Ddebian${i}
	if [ ! -e "$LOGDIR" ] ; then
	    break
	fi
	if [ "$i" =3D "END" ] ; then
	    log "No space in the storage media."
	    exit 1
	fi
    done
    log "Save d-i install logs to $LOGDIR"
    mkdir /floppy/$LOGDIR
    for file in \
	    /var/log/messages \
	    /var/log/syslog \
	    /var/log/partman \
	    $DILOGDIR/hardware-summary \
	    $DILOGDIR/package-versions; do=20
	if [ -e $file ]; then
	    cp $file /floppy/$LOGDIR/
	fi
    done

    umount /floppy 2>/dev/null || true
    db_progress STEP 1
    db_progress STOP
else
    db_progress STEP 1
    db_progress STOP
    db_input critical bugreporter-udeb/no_floppy || [ $? -eq 30 ]
    db_go
fi

--NzB8fVQJ5HfG6fxh--

--i0/AhcQY5QxfSsSZ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBJwGh6A/EwagGHzIRAjpVAJsGLUbwyeLwuUVgtnmjAxorda+A0wCeIaa+
A4FfESSUdLXfib1+kB2CL9o=
=6D28
-----END PGP SIGNATURE-----

--i0/AhcQY5QxfSsSZ--

---------------------------------------
Received: (at 267219-close) by bugs.debian.org; 17 May 2005 17:10:18 +0000
>From jeroen@newraff.debian.org Tue May 17 10:10:18 2005
Return-path: <jeroen@newraff.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1DY5aD-000329-00; Tue, 17 May 2005 10:10:17 -0700
Received: from jeroen by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1DY5WY-0000os-00; Tue, 17 May 2005 13:06:30 -0400
From: Joey Hess <joeyh@debian.org>
To: 267219-close@bugs.debian.org
X-Katie: lisa $Revision: 1.30 $
Subject: Bug#267219: fixed in installation-report 2.0
Message-Id: <E1DY5WY-0000os-00@newraff.debian.org>
Sender: Jeroen van Wolffelaar <jeroen@newraff.debian.org>
Date: Tue, 17 May 2005 13:06:30 -0400
Delivered-To: 267219-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.2 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
	REMOVE_REMOVAL_NEAR autolearn=no 
	version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level: 
X-CrossAssassin-Score: 3

Source: installation-report
Source-Version: 2.0

We believe that the bug you reported is fixed in the latest version of
installation-report, which is due to be installed in the Debian FTP archive:

installation-report_2.0.dsc
  to pool/main/i/installation-report/installation-report_2.0.dsc
installation-report_2.0.tar.gz
  to pool/main/i/installation-report/installation-report_2.0.tar.gz
installation-report_2.0_all.deb
  to pool/main/i/installation-report/installation-report_2.0_all.deb
save-logs_2.0_all.udeb
  to pool/main/i/installation-report/save-logs_2.0_all.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 267219@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <joeyh@debian.org> (supplier of updated installation-report package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 15 May 2005 20:02:11 -0400
Source: installation-report
Binary: save-logs installation-report
Architecture: source all
Version: 2.0
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Joey Hess <joeyh@debian.org>
Description: 
 installation-report - system installation report
 save-logs  - save logs and configuration for debug purposes (udeb)
Closes: 220306 221575 267219
Changes: 
 installation-report (2.0) unstable; urgency=low
 .
   * Colin Watson
     - Remove dead (since r12587) copy_cdebconf_db code.
   * Joey Hess
     - Stop using package-versions in postinst too (just copy status file),
       and remove the script.
     - Remove some hardcoded /bin paths.
     - Depend on the new mountfloppy udeb, and use the mountfloppy command
       to get the floppy mounted. This means it can prompt for a floppy device
       if it doesn't find the floppy, and so there is usb floppy support,
       assuming the usb mass storage modules have been loaded by hw-detect
       or the boot floppy. Closes: #220306, #221575
     - Remove udeb extended description.
     - Minor indentation cleanups.
     - Reword the message if floppy mount fails.
     - Add "httpd", a very simple http server, and add a menu that can be used
       to start it.
     - Add support for saving debug logs to a mounted filesystem. If /hd-media
       is already mounted, offer it as the default to support USB keys,
       otherwise the user must mount the filesystem by hand. Closes: #267219
     - Use an error template for failed floppy mount.
     - Take down the progress bar if saving a log failed.
     - Save log files to an "install" subdir of the floppy or filesystem;
       if "install" exists go on to "install.2", etc.
     - Cut down on the hardcoded paths to commands.
     - Remove the hdparm stuff that has never really worked, and that
       is dependent on kernels compiled with devfs.
     - Make report-hw work on regular Debian as well as on d-i, various
       improvements.
     - Add cardctl ident and status to report-hw.
     - Include /proc/bus/usb/devices in report-hw.
     - Add uname -a and free output to report-hw.
     - Add installation-report package, rename bugreporter-udeb to save-logs
       (more accurate), and rename source package to installation-logs.
     - installation-report package has reportbug integration to semi-automate
       a user filing an installation report.
     - Add a man page for report-hw.
     - Add myself to uploaders.
     - Most of the log saving code moved to here from prebaseconfig,
       and the logs moved to /var/log/installer.
     - Reworded and reorganised the installation report template, to
       better prompt the user for info we need. Move hardware info to end,
       and prompt for a log file.
     - Depend on prebaseconfig 1.08.
     - Add /proc/bus/input/devices to report-hw output.
     - If /etc/lsb-release exists in the installer, include it in the log
       files.
   * Updated translations:
     - Arabic (ar.po) by Ossama M. Khayat
     - Bulgarian (bg.po) by Ognyan Kulev
     - Bosnian (bs.po) by Safir Å eÄ?eroviÄ?
     - Catalan (ca.po) by Guillem Jover
     - Czech (cs.po) by Miroslav Kure
     - Welsh (cy.po) by Dafydd Harries
     - Danish (da.po) by Claus Hindsgaul
     - German (de.po) by Herbert Straub
     - Greek, Modern (1453-) (el.po) by Kostas Papadimas
     - Spanish (es.po) by Enrique Matias Sanchez
     - Basque (eu.po) by Piarres Beobide
     - Finnish (fi.po) by Tapio Lehtonen
     - French (fr.po) by Christian Perrier
     - Gallegan (gl.po) by Jacobo Tarrio
     - Hebrew (he.po) by Lior Kaplan
     - Croatian (hr.po) by Krunoslav Gernhard
     - Hungarian (hu.po) by Gabor Burjan
     - Indonesian (id.po) by Yoppy Hidayanto
     - Italian (it.po) by Stefano Canepa
     - Japanese (ja.po) by Kenshi Muto
     - Korean (ko.po) by Changwoo Ryu
     - Lithuanian (lt.po) by KÄ?stutis BiliÅ«nas
     - Latvian (lv.po) by Aigars Mahinovs
     - Bokmål, Norwegian (nb.po) by Terance Edward Sola
     - Dutch (nl.po) by Bart Cornelis
     - Norwegian Nynorsk (nn.po) by HÃ¥vard Korsvoll
     - Polish (pl.po) by Dominik Zablotny
     - Portuguese (pt.po) by Miguel Figueiredo
     - Portuguese (Brazil) (pt_BR.po) by Carlos Eduardo Pedroza Santiviago
     - Romanian (ro.po) by Ovidiu Damian
     - Russian (ru.po) by Yuri Kozlov
     - Slovak (sk.po) by Peter KLFMANiK Mann
     - Slovenian (sl.po) by Jure Ä?uhalev
     - Albanian (sq.po) by Elian Myftiu
     - Swedish (sv.po) by Per Olofsson
     - Turkish (tr.po) by Recai OktaÅ?
     - Ukrainian (uk.po) by Eugeniy Meshcheryakov
     - Simplified Chinese (zh_CN.po) by Carlos Z.F. Liu
     - Traditional Chinese (zh_TW.po) by Tetralet
Files: 
 1ae0960d9beac7e16fd3d55398ec7d28 684 debian-installer optional installation-report_2.0.dsc
 65c75162e3716630874f8bb97325e412 30642 debian-installer optional installation-report_2.0.tar.gz
 fa4699c929656cca795e2f2b36c56374 8998 debian-installer standard save-logs_2.0_all.udeb
 15fd588b5961ac53aa58308b09f29670 10814 misc optional installation-report_2.0_all.deb
package-type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFCh+TY2tp5zXiKP0wRAsGRAJwOe7fwKdzDKr4UK4eI9jw8qcSj6ACeL3k/
EM0SvNzVyOjZRQOO8zHTl40=
=Y3uR
-----END PGP SIGNATURE-----



Reply to: