[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#303914: partman-partitioning: should not allow to partition LVM LVs or SW RAID devices



reassign 303914 partman
tags 303914 + patch
tags 303914 + d-i
thanks

Patch that fixes this bug attached. It will not allow crating partition
tables on any "disk" of type "loop" (including LVM LVs ans SW RAID).

I tested patch in qemu, it works for both LVM and RAID.

09.04.2005 о 20:02 +0300 Eugeniy Meshcheryakov написав(-ла):
> Package: partman-partitioning
> Severity: normal
> 
> Making partition tables on LVM LVs or SW RAID devices should not be
> allowed. Both do not support partition tables on them.
> 

-- 
Eugeniy Meshcheryakov

Kyiv National Taras Shevchenko University
Information and Computing Centre
http://icc.univ.kiev.ua
Index: choose_partition/partition_tree/do_option
===================================================================
--- choose_partition/partition_tree/do_option	(revision 26651)
+++ choose_partition/partition_tree/do_option	(working copy)
@@ -11,6 +11,13 @@
 
 if [ -z "$id" ]; then
 #    ask_user /lib/partman/storage_device "$dev" "$id" || true
+    open_dialog GET_DISK_TYPE
+    read_line x
+    close_dialog
+    # do not try to create partition table on sw RAID device or LVM LV
+    if [ "$x" = loop ]; then
+        exit 0
+    fi
     mklabel=$(echo /lib/partman/storage_device/[0-9][0-9]label/do_option)
     [ -x "$mklabel" ] || exit 0
     $mklabel label "$dev" || true

Reply to: