[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#262868: Fix for the free space problem



tags 262868 patch
thanks

Hi,

I was able to trace this problem down to the enable_swap call in the storage_device/label/do_option script of partman-partitioning udeb. As I understand, the device on which the operations are performed is passed to parted_server automatically, based on the current working directory. The call to enable_swap in the above script actually changes the working directory while rescanning the partitions, and "forgets" to restore it to the correct original value on exit. As a result, on a system with more than one disk the subsequent operations may be performed on the disk different from the one they are actually meant for, leading to erratic behavior. A simple patch seems to take care of the problem:

--snip-------------------------------------------------------------------
diff -aur partman-partitioning-32_orig/storage_device/label/do_option partman-partitioning-32/storage_device/label/do_option
--- partman-partitioning-32_orig/storage_device/label/do_option	2004-10-29 15:08:01.000000000 -0400
+++ partman-partitioning-32/storage_device/label/do_option	2004-12-09 00:58:51.000000000 -0500
@@ -55,6 +55,7 @@
     open_dialog UNDO
     close_dialog
     enable_swap
+    cd $dev
 fi

 # Different types partition tables support different visuals.  Some
--snip-------------------------------------------------------------------

Another valid solution would be to fix enable_swap to save PWD on entry and restore it on return.

Best regards,

Jurij Smakov                                        jurij@wooyd.org
Key: http://www.wooyd.org/pgpkey/                   KeyID: C99E03CC



Reply to: