[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r23178 - in trunk/packages/rootskel: debian src/lib/debian-installer.d



At 17 Oct 04 19:08:18 GMT,
Joey Hess wrote:
> > > Enable UTF-8 on serial console. (closes: #263137)
> > 
> > This is nonsense, the escape-codes are linux only.
> 
> This has a potential to block or break the initrd builds which I need to
> redo very soon to fix powerpc floppy sizes. Can we get a quick
> decision on whether to keep or drop this change please.

I wonder why this change relates with size (add around 10 bytes?).
UTF-8 support for serial console doesn't need any additional files.

Again, "forget export LANG" causes a problematic hang up on
non-English environment.
Here is my new proposal patch. Escape sequence is applied only if
TERM_TYPE=virtual.

--- src/lib/debian-installer.d/S40term-linux    (revision 23190)
+++ src/lib/debian-installer.d/S40term-linux    (working copy)
@@ -2,13 +2,13 @@
  if [ "$TERM_TYPE" = virtual ]; then
    echo -ne "\033[9;0]" # Turn off console blanking.
  fi
+fi

- # Enable UTF-8 locale if it is available
- if [ -d /usr/lib/locale/C.UTF-8 ]; then
-   TERM_UTF8=yes
-   export LANG=C.UTF-8
-   if [ "$TERM_TYPE" = virtual ]; then
-     echo -ne "\033%G" # Enable UTF-8 console
-   fi
+# Enable UTF-8 locale if it is available
+if [ -d /usr/lib/locale/C.UTF-8 ]; then
+ TERM_UTF8=yes
+ export LANG=C.UTF-8
+ if [ "$TERM_TYPE" = virtual ]; then
+   echo -ne "\033%G" # Enable UTF-8 console
  fi
 fi



Reply to: