Bug#273109: base-config: Choosing not to start an display manager leaves menu unexitable

[Paul Hampson <Paul.Hampson@anu.edu.au>]

Package: base-config
Version: 2.45
Severity: important

/usr/lib/base-config/menu/finish calls itself with
$0 debconf 0
if no display manager is to be started, or 
$0 debconf 1
if a display manager is to be done.

However, switching against $1, the debconf) option has:
ask_dm="$1"
if [ "$ask_dm" ]; then
	<Ask about display manager>
fi
<This code returns failure if no display manager was chosen but
the above stanza was run.>

Now here, $1 is "debconf" not the "1" or "0" it is obviously
meant to be checking for. _Also_, changing to
ask_dm="$2"
doesn't work since
[ "0" ]
is _true_.

I think what was meant is:
ask_dm="$2"
if [ $ask_dm -eq 1 ]; then
	<Same code here for choosing a display manager to run>
fi
<Same>

The same 
if [ "$ask_dm" ]; then
	...
fi
stanza appears later on in the debconf) section.

This actually occurred to me in 2.40.5 (from Testing), but I've
just looked and the code is the same.

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.5
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8

Versions of packages base-config depends on:
ii  adduser                 3.59             Add and remove users and groups
ii  apt                     0.5.27           Advanced front-end for dpkg
ii  bsdutils                1:2.12-8         Basic utilities from 4.4BSD-Lite
ii  console-data            2002.12.04dbs-46 Keymaps, fonts, charset maps, fall
ii  console-tools           1:0.2.3dbs-55    Linux console and font utilities
ii  debconf                 1.4.36           Debian configuration management sy
ii  debianutils             2.10.1           Miscellaneous utilities specific t
ii  gettext-base            0.14.1-5         GNU Internationalization utilities
ii  passwd                  1:4.0.3-30.1     Change and administer password and

-- debconf information excluded