[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#258823: [patch] anna: Add check for presence of kernel version udebs (untested)



On Wednesday 08 September 2004 17:36, Frans Pop wrote:
> Please check very carefully as my knowledge of both anna and C is very
> limited :-(

+    while (!kernel_packages_present) {
+        *packages_allocator = di_system_packages_allocator_alloc();
+        *packages = get_packages(*packages_allocator);
+
+        while (*packages == NULL) {
+            int status=retriever_handle_error("packages");
+            di_log(DI_LOG_LEVEL_WARNING, "bad d-i Packages file");
+            if (status != 1) {
+                /* Failed to handle error. */
+                return 4;
+            }
+            else {
+                /* Error handled, retry. */
+                *packages_allocator = di_system_packages_allocator_alloc();
+                *packages = get_packages(*packages_allocator);
+            }
+        }

i may be mistaken, but to me it looks like this'll go into an infinite loop
  when get_packages keeps returning null  (no packages available, i guess)
  and retriever_handle_error keeps returning 1  (normal, i guess)

i know nothing of installer code, so i hope i'm not completely off base.

have fun,

  Siward



Reply to: