Bug#261256: marked as done (languagechooser: Should enable selected locale in /target/)
Your message dated Tue, 07 Sep 2004 16:17:14 -0400
with message-id <E1C4mOw-00022c-00@newraff.debian.org>
and subject line Bug#261256: fixed in languagechooser 1.30
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Jul 2004 16:28:50 +0000
>From pere@gigs.hungry.com Sat Jul 24 09:28:50 2004
Return-path: <pere@gigs.hungry.com>
Received: from 217-13-7-10.dd.nextgentel.com (minerva.hungry.com) [217.13.7.10]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BoPOD-00055R-00; Sat, 24 Jul 2004 09:28:50 -0700
Received: from pere by minerva.hungry.com with local (Exim 3.35 #1 (Debian))
id 1BoPNi-0001tG-00; Sat, 24 Jul 2004 18:28:18 +0200
To: submit@bugs.debian.org
Subject: languagechooser: Should enable selected locale in /target/
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <E1BoPNi-0001tG-00@minerva.hungry.com>
Sender: Petter Reinholdtsen <pere@gigs.hungry.com>
Date: Sat, 24 Jul 2004 18:28:18 +0200
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Package: languagechooser
Version: 1.28
Tags: d-i patch
At the moment, the locale needed in the second stage of the
installation is generated by termwrap before base-config starts. I
believe it would be better if this is done in the prebaseconfig script
in languagechooser. Even better would be to get the locales package
to handle it, but I am not sure how to do that. It is installed by
base-installer, and there is no way to tell it which locale it should
generate.
Here is a patch to enable this.
Index: prebaseconfig
===================================================================
--- prebaseconfig (revision 18320)
+++ prebaseconfig (working copy)
@@ -2,6 +2,8 @@
. /usr/share/debconf/confmodule
+LOG=/var/log/messages
+
modify_cyrconfig() {
if [ "$2" ]; then
sed -e "s/^$1 .*\$/$1 $2/" \
@@ -76,3 +78,19 @@
echo "LANG_INST=\"$LOCALE\""
echo "LANGUAGE_INST=\"$LANGLIST\""
) >> /target/root/dbootstrap_settings
+
+# Set global locale and language, and make sure the glibc locale is
+# generated. This task is also done in termwrap and base-config, and
+# should probably be removed from there when this part work.
+(
+ echo "LANG=\"$LOCALE\"
+ echo "LANGUAGE=\"$LANGLIST\""
+) >> /target/etc/environment
+# If the locale isn't already valid, append it to locale.gen
+if chroot /target/ /usr/sbin/validlocale $LOCALE \
+ >> /target/etc/locale.gen 2> $LOG ; then
+ : # Nothing to do
+else
+ # New locale added to locale.gen, generate it
+ chroot /target /usr/sbin/locale-gen > $LOG 2>&1
+fi
When this patch is enabled, we should modify termwrap to only check if
the locale is available, and to not generate it if it isn't.
---------------------------------------
Received: (at 261256-close) by bugs.debian.org; 7 Sep 2004 20:23:51 +0000
>From katie@ftp-master.debian.org Tue Sep 07 13:23:51 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1C4mVL-0004ld-00; Tue, 07 Sep 2004 13:23:51 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1C4mOw-00022c-00; Tue, 07 Sep 2004 16:17:14 -0400
From: Christian Perrier <bubulle@debian.org>
To: 261256-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#261256: fixed in languagechooser 1.30
Message-Id: <E1C4mOw-00022c-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Tue, 07 Sep 2004 16:17:14 -0400
Delivered-To: 261256-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
Source: languagechooser
Source-Version: 1.30
We believe that the bug you reported is fixed in the latest version of
languagechooser, which is due to be installed in the Debian FTP archive:
languagechooser_1.30.dsc
to pool/main/l/languagechooser/languagechooser_1.30.dsc
languagechooser_1.30.tar.gz
to pool/main/l/languagechooser/languagechooser_1.30.tar.gz
languagechooser_1.30_all.udeb
to pool/main/l/languagechooser/languagechooser_1.30_all.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 261256@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Christian Perrier <bubulle@debian.org> (supplier of updated languagechooser package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Tue, 7 Sep 2004 22:06:24 +0200
Source: languagechooser
Binary: languagechooser
Architecture: source all
Version: 1.30
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Christian Perrier <bubulle@debian.org>
Description:
languagechooser - Choose language (udeb)
Closes: 261256 261476 261671 265161 266103
Changes:
languagechooser (1.30) unstable; urgency=low
.
* Added Hindi to the list of choices. Thanks to Pankaj Kaushal (sp0onman)
for the help on initial steps. Choice is commented because Hindi
currently not displayable.
* Use correct English name (Persian) for "fa"
* Ognyan Kulev
- Use console-cyrillic setup in languagelist entry for Bulgarian.
(Closes: #261476)
* Petter Reinholdtsen
- generate the locale needed in 2nd stage in prebaseconfig. Closes: #261256
* Christian Perrier
- set console font with APP_CHARSET_MAP for the first 6 virtual consoles
Closes: #266103
- Corrected entry for Slovenian. Thanks to Jure Cuhalev
- Translated entry for Vietnamese. Thanks to Jean-Christophe André
- Check all languages names translations with translators. No more
English names left. Closes: #261671
- Add a default country for all languages. Closes: #265161
* Konstantinos Margaritis
- prebaseconfig:
- Install localization-config when locale!=en_US
Files:
879b6fca6ef34bdfadace1186ce7c4e4 662 debian-installer standard languagechooser_1.30.dsc
9051813042a229378398f2091048354d 31716 debian-installer standard languagechooser_1.30.tar.gz
a92862513ce12661c1263f264bb44dcb 7202 debian-installer standard languagechooser_1.30_all.udeb
package-type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
iD8DBQFBPhXS1OXtrMAUPS0RAuJRAKCJ3zDEUW+EQ+dqa+dCkTnoA8rclQCeNiYd
G3AtofxeF6yjdDvFdc6zIQk=
=0XES
-----END PGP SIGNATURE-----
Reply to: