I took a look at this patch (well, it should have been presented as a patch). I have a lot of problems with it. - To start with, there is a lot of reindentation of blocks of code. This makes it hard to follow your changes, and I was happy with the way it was indented. This is a good way to get your patches rejected out of hand, FWIW. - Some blocks of code are moved around in ways that change nothing, this also obfuscates the true changes of the patch. - I doubt that REPORT_MEDIA_DEV is useful. By the time you need to use the bugreporter, you've already booted, and you probably did not boot with REPORT_MEDIA_DEV. We are not in a string freeze. Feel free to add questions instead. - The postinst used to make sure that the floppy module was loaded, but the patch removes that. - I don't understand why you have it modprobe ide-core. modprobe usb-storage should automatically load all modules it needs, including ide-code. - It does not take into account that one common use of usb memory sticks is to boot the installer from them. If you've booted the installer, then the memory stick is already mounted at hd-media, and bugreporter will be unable to remount it to /floppy. - /floppy is no longer the correct mount point to use, it should use /mnt or somehing. - The postinst used to make sure that the vfat module was loaded, but your patch removes this for some reason. - This should really be two separate patches, because supporting usb media is one discrete idea, and allowing multiple reports to be stored to a floppy is another. I have many issues with the part of the patch that deals with multiple installation reports, but I will ignore that part since I think it should be in a different patch. -- see shy jo
Attachment:
signature.asc
Description: Digital signature