[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#250789: Please fix this bug!



[Eugeniy Meshcheryakov]
> Why do this? This does not needed for installer.

At the moment, termwrap is a generic tool capable of running a program
in the console with the requested locale and console font.  And as
such, it need to do stuff before the program is executed, and undo it
after it is done.  The patch removed the 'undo' part, and is not
correct.

I think a more interesting question is how do we want to run
base-config during the installation, and which tasks should be done by
d-i, and which should be left for base-config.  I've now read all the
messages in bug #250789, and is a little wiser.  I notice that the old
assumtion used in termwrap and base-config is no longer true, and
believe this should have some effect on how we distribute the work
between scripts.  When termwrap was modified to generate the locale
and set the console font, there were nothing else doing this, and
changing boot-floppies was out of the question, so it had to be done
in base-config.  Now, the console font is set console-tools, so this
task is no longer needed by termwrap.

The locale generation belongs to the locales package, but is not yet
done there, so we need to do it somewhere else for now.  I suggest
moving it to the prebaseconfig script of languagechooser

The only think we need termwrap for then is to wrap a UTF-8 frame
buffer terminal around base-config for the languages with more then
512 glyphs.

I suggest we patch languagechooser to update /etc/locale.gen and
/etc/environment to set the default locale, and remove the locale
generating code from termwrap.  I also suggest we teach termwarp to
look in the data file for console-tool (is this
/etc/console-tool/config?  The variables seem to be SCREEN_FONT and
SCREEN_FONT_MAP), and tell it to use these values if available as the
default instead of ISO-8859-1.  This way the termwrap tool is still a
generic wrapper to run programs with correct console font and locale,
while the locale generating is moved to a more sensible place.

Care to make a patch for termwrap?  I already have a patch for
languagechooser available.



Reply to: