[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#221602: marked as done (grub-installer: Should enable serial console on serial line installs)



Your message dated Mon, 19 Jul 2004 01:12:40 +0200
with message-id <20040718231240.GA5513@uio.no>
and subject line 221602 closed by grub-installer 0.51
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 19 Nov 2003 09:25:52 +0000
>From pre@saruman.uio.no Wed Nov 19 03:25:52 2003
Return-path: <pre@saruman.uio.no>
Received: from pat.uio.no [129.240.130.16] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1AMOat-0002eT-00; Wed, 19 Nov 2003 03:25:51 -0600
Received: from mail-mx3.uio.no ([129.240.10.44])
	by pat.uio.no with esmtp (Exim 4.20)
	id 1AMOas-0006sW-Qm
	for submit@bugs.debian.org; Wed, 19 Nov 2003 10:25:50 +0100
Received: from saruman.uio.no ([129.240.201.202])
	by mail-mx3.uio.no with esmtp (Exim 4.14)
	id 1AMOaq-0001jf-1h; Wed, 19 Nov 2003 10:25:48 +0100
Received: from pre by saruman.uio.no with local (Exim 2.12 #7)
	id 1AMOap-0002TP-00; Wed, 19 Nov 2003 10:25:47 +0100
To: submit@bugs.debian.org
Subject: grub-installer: Should enable serial console on serial line installs
From: Petter Reinholdtsen <pere@hungry.com>
Message-Id: <E1AMOap-0002TP-00@saruman.uio.no>
Sender: Petter Reinholdtsen <petter.reinholdtsen@usit.uio.no>
Date: Wed, 19 Nov 2003 10:25:47 +0100
X-MailScanner-Information: This message has been scanned for viruses/spam. Contact postmaster@uio.no if you have questions about this scanning
X-UiO-MailScanner: No virus found
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0
	tests=HAS_PACKAGE
	version=2.53-bugs.debian.org_2003_11_15
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_11_15 (1.174.2.15-2003-03-30-exp)


Package:  grub-installer
Version:  0.24
Severity: important

When installing using a serial line console, grub-installer should
enable the serial line console at boot time when installed.  This is
from a installation report:

  I mentioned that I was on a serial console.  I had to use the
  installer as a rescue again in order to get a shell so I could add
  the boot parameters back into the grub configuration file:
  console=ttyS0,9600n8.  Could this not be saved from the inital boot
  parameters and applied to the config?  Or at least ask about adding
  it?  The ability to add these parmeters in could be critical in
  installs such as this. And since the first reboot is a critical
  configuration step (base-config), not having access +like this could
  i potentially break the install.

As far as I see, there is no code in grub-installer to detect a serial
console, and no way to pass the extra parameter into grub-install or
update-grub.  There is code in lilo-installer to support serial
console.

  # Use a serial console if current default console is a serial port.
  # default console is last listed
  defconsole=$(sed -e 's/.*console=/console=/' /proc/cmdline)
  if echo "${defconsole}" | grep -q console=ttyS; then
      PORT=$(echo "${defconsole}" | sed -e 's%^console=ttyS%%' -e 's%,.*%%')
      SPEED=$(echo "${defconsole}" | sed -e 's%^console=ttyS[0-9]\+,%%' -e 's% .*%%')
      SERIAL="${PORT},${SPEED}"

      db_subst lilo-installer/serial-console PORT "ttyS${PORT}"
      db_subst lilo-installer/serial-console SPEED "${SPEED}"
      db_input medium lilo-installer/serial-console || [ $? -eq 30 ]
      db_go || true
  fi
  [...]
  if [ "${SERIAL}" ]; then
      echo "serial=${SERIAL}" >> /target/etc/lilo.conf
  fi
  [...]
  if [ "${SERIAL}" ]; then
      echo "      append=\"console=ttyS${SERIAL}\"" >> /target/etc/lilo.conf
  fi

Perhaps this code should be generalized, and moved into rootskel?  We
could set some cdebconf template variables to flag that the install is
a serial line, set the port device and the speed, and let the
{grub,lilo}-installer use these values.

---------------------------------------
Received: (at 221602-done) by bugs.debian.org; 18 Jul 2004 23:12:42 +0000
>From sesse@samfundet.no Sun Jul 18 16:12:42 2004
Return-path: <sesse@samfundet.no>
Received: from trofast.sesse.net [129.241.93.32] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BmKpm-0003Oc-00; Sun, 18 Jul 2004 16:12:42 -0700
Received: from sesse by trofast.sesse.net with local (Exim 3.36 #1 (Debian))
	id 1BmKpk-0001R9-00
	for <221602-done@bugs.debian.org>; Mon, 19 Jul 2004 01:12:40 +0200
Date: Mon, 19 Jul 2004 01:12:40 +0200
From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: 221602-done@bugs.debian.org
Subject: 221602 closed by grub-installer 0.51
Message-ID: <20040718231240.GA5513@uio.no>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Operating-System: Linux 2.6.6 on a i686
User-Agent: Mutt/1.5.6+20040523i
Delivered-To: 221602-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.0 required=4.0 tests=BAYES_00,SPAMBUGNUMSUBJ 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

As far as I can see, grub-installer 0.51 added serial console support, but
forgot to close bug #221602 ("grub-installer: Should enable serial console on
serial line"), so I'm closing it now. A 242 day old bug squashed, hooray! :-)

/* Steinar */
-- 
Homepage: http://www.sesse.net/



Reply to: