Bug#259604: marked as done (Subject: s390-netdevice: CTC default protocol incorrect)
Your message dated Sun, 18 Jul 2004 17:02:05 -0400
with message-id <E1BmInN-00078U-00@newraff.debian.org>
and subject line Bug#259604: fixed in s390-netdevice 0.0.6
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Jul 2004 17:51:50 +0000
>From athornton@sinenomine.net Thu Jul 15 10:51:50 2004
Return-path: <athornton@sinenomine.net>
Received: from sine.sctelecom.com (mailbox.sinenomine.net) [192.204.203.218]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BlAOb-0006QD-00; Thu, 15 Jul 2004 10:51:50 -0700
Received: from localhost (mailbox.sinenomine.net [192.168.101.9])
by mailbox.sinenomine.net (8.12.6/8.12.6/SuSE Linux 0.6) with ESMTP id i6FHpijb025118
for <submit@bugs.debian.org>; Thu, 15 Jul 2004 13:51:45 -0400
Subject: Subject: s390-netdevice: CTC default protocol incorrect
From: Adam Thornton <athornton@sinenomine.net>
To: submit@bugs.debian.org
Content-Type: multipart/mixed; boundary="=-3XjjfNT40dnj9jd22YIk"
Organization: Sine Nomine Associates
Message-Id: <[🔎] 1089914066.30083.136.camel@dev-linux.fsf.net>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.4.4
Date: Thu, 15 Jul 2004 12:54:26 -0500
X-Virus-Scanned: by AMaViS - amavis-milter (http://www.amavis.org/)
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
--=-3XjjfNT40dnj9jd22YIk
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Package: s390-netdevice
Version: 0.06
Severity: important
Tags: patch
Protocol 1 (Linux) is currently chosen as the default CTC protocol, and
the debconf priority is medium. This means that CTC installation under
VM (usually--if the CTC is defined as vCTCs typically are) would fail,
and CTC installation on Hercules would fail, both silently and
confusingly.
The patch to the template simply changes the default to "0" which is
correct for Hercules and most VM installations, and also raises the
debconf priority to critical. I don't know that the second thing is
correct, but IMHO it's better for the user to have to answer or take a
default on an unnecessary question than for the installation to fail.
We might want to add something to the template saying "Hercules users
should choose 0, and VM users should choose the protocol defined in
PROFILE TCPIP for the CTC link to the Debian guest." I couldn't figure
out a clear and more concise way to say that, though.
The rest of the netdevice.c patch is just the leftover IUCV fix (because
the module name is netiucv--just the iucv module doesn't do you any
good). That issue is bug #258430.
Adam
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (700, 'testing')
Architecture: s390
Kernel: Linux 2.4.17
Locale: LANG=C, LC_CTYPE=C
--=-3XjjfNT40dnj9jd22YIk
Content-Disposition: attachment; filename=s390-netdevice-templates.patch
Content-Type: text/plain; name=s390-netdevice-templates.patch; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
--- s390-netdevice.templates.orig 2004-07-15 13:26:41.000000000 -0400
+++ s390-netdevice.templates 2004-07-15 12:57:32.000000000 -0400
@@ -30,7 +30,7 @@
Template: debian-installer/s390/netdevice/ctc/protocol
Type: select
Choices: S/390 (0), Linux (1), OS/390 (3)
-Default: Linux (1)
+Default: S/390 (0)
_Description: Protocol for this connection:
Template: debian-installer/s390/netdevice/lcs/choose
--=-3XjjfNT40dnj9jd22YIk
Content-Disposition: attachment; filename=netdevice.c.patch
Content-Type: text/plain; name=netdevice.c.patch; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
--- netdevice.c.orig 2004-07-15 13:26:02.000000000 -0400
+++ netdevice.c 2004-07-15 12:55:36.000000000 -0400
@@ -298,7 +298,7 @@
static int get_ctc_protocol (void)
{
char *ptr;
- int ret = my_debconf_input ("medium", TEMPLATE_PREFIX "ctc/protocol", &ptr);
+ int ret = my_debconf_input ("critical", TEMPLATE_PREFIX "ctc/protocol", &ptr);
if (ret)
return ret;
@@ -476,7 +476,7 @@
static int setup (void)
{
FILE *f;
- char buf[256], buf1[256] = "", *ptr = NULL;
+ char buf[256], buf1[256] = "", buf2[256], *ptr = NULL;
if (mkdir ("/etc/modutils", 777) && errno != EEXIST)
return 1;
@@ -486,6 +486,7 @@
case TYPE_QETH:
case TYPE_CTC:
case TYPE_LCS:
+ strncpy(buf2,type_text,sizeof(type_text));
if (strlen (chandev_parm))
ptr = chandev_parm;
@@ -521,6 +522,10 @@
break;
case TYPE_IUCV:
+ strncpy(buf2,"netiucv",sizeof("netiucv"));
+ /* This is necessary because the "iucv" module */
+ /* provides the basic IUCV functions, but the */
+ /* "netiucv" module provides TCP/IP support. */
f = fopen("/etc/modutils/netiucv", "a");
if (!f)
return 1;
@@ -532,7 +537,7 @@
break;
}
- snprintf (buf, sizeof (buf), "modprobe %s %s", type_text, buf1);
+ snprintf (buf, sizeof (buf), "modprobe %s %s", buf2, buf1);
di_exec_shell_log (buf);
--=-3XjjfNT40dnj9jd22YIk--
---------------------------------------
Received: (at 259604-close) by bugs.debian.org; 18 Jul 2004 21:08:36 +0000
>From katie@ftp-master.debian.org Sun Jul 18 14:08:36 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BmItg-00061N-00; Sun, 18 Jul 2004 14:08:36 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
id 1BmInN-00078U-00; Sun, 18 Jul 2004 17:02:05 -0400
From: Bastian Blank <waldi@debian.org>
To: 259604-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#259604: fixed in s390-netdevice 0.0.6
Message-Id: <E1BmInN-00078U-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Sun, 18 Jul 2004 17:02:05 -0400
Delivered-To: 259604-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 3
Source: s390-netdevice
Source-Version: 0.0.6
We believe that the bug you reported is fixed in the latest version of
s390-netdevice, which is due to be installed in the Debian FTP archive:
s390-netdevice_0.0.6.dsc
to pool/main/s/s390-netdevice/s390-netdevice_0.0.6.dsc
s390-netdevice_0.0.6.tar.gz
to pool/main/s/s390-netdevice/s390-netdevice_0.0.6.tar.gz
s390-netdevice_0.0.6_s390.udeb
to pool/main/s/s390-netdevice/s390-netdevice_0.0.6_s390.udeb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 259604@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Blank <waldi@debian.org> (supplier of updated s390-netdevice package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 18 Jul 2004 22:47:44 +0200
Source: s390-netdevice
Binary: s390-netdevice
Architecture: source s390
Version: 0.0.6
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Bastian Blank <waldi@debian.org>
Description:
s390-netdevice - Configure network hardware (udeb)
Closes: 258108 258430 259604
Changes:
s390-netdevice (0.0.6) unstable; urgency=low
.
* Adam Thornton
- Changed priority of CTC protocol question and default protocol.
(closes: #259604)
* Bastian Blank
- Add iucv support. Derived patch from Adam Thornton.
(closes: #258108, #258430)
* Christian Perrier
- reworded the "Is this configuration correct?" question for being less
dependent on debconf interface. Run debconf-updatepo
* Updated translations:
- Bulgarian (bg.po) by Ognyan Kulev
- Bosnian (bs.po) by Safir Å eÄ?eroviÄ?
- Catalan (ca.po) by Jordi Mallach
- Czech (cs.po) by Miroslav Kure
- Danish (da.po) by Claus Hindsgaul
- German (de.po) by Dennis Stampfer
- Greek (el.po) by George Papamichelakis
- Spanish (es.po) by Teófilo Ruiz Suárez
- Basque (eu.po) by Piarres Beobide Egaña
- Finnish (fi.po) by Tapio Lehtonen
- French (fr.po) by Christian Perrier
- Hebrew (he.po) by Lior Kaplan
- Hungarian (hu.po) by VER�K István
- Indonesian (id.po) by Parlin Imanuel Toh
- Japanese (ja.po) by Kenshi Muto
- Korean (ko.po) by Changwoo Ryu
- Lithuanian (lt.po) by Marius Gedminas
- Dutch (nl.po) by Bart Cornelis
- Norwegian (nn.po) by HÃ¥vard Korsvoll
- Polish (pl.po) by Bartosz Fenski
- Portuguese (Brazil) (pt_BR.po) by André LuÃs Lopes
- Portuguese (pt.po) by Miguel Figueiredo
- Romanian (ro.po) by Eddy Petrisor
- Russian (ru.po) by Nikolai Prokoschenko
- Slovak (sk.po) by Peter KLFMANiK Mann
- Albanian (sq.po) by Elian Myftiu
- Turkish (tr.po) by Osman Yüksel
- Ukrainian (uk.po) by Eugeniy Meshcheryakov
- Simplified Chinese (zh_CN.po) by Carlos Z.F. Liu
Files:
ad573ef61f4646512c97ce5064bd058a 677 debian-installer optional s390-netdevice_0.0.6.dsc
57e907c94d0924089cb25435fff657ad 60617 debian-installer optional s390-netdevice_0.0.6.tar.gz
76f55da19b955a01bc14f4b036ebbdbb 48648 debian-installer optional s390-netdevice_0.0.6_s390.udeb
package-type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iEYEARECAAYFAkD64xsACgkQLkAIIn9ODhGlYwCgpOyXoBVAJKz/d8hnZJIYcp+e
+N4An2pMXgChZ8LpbFyMTt8/bmJcN6lu
=BYxN
-----END PGP SIGNATURE-----
Reply to: