pcmcia-cs not to call ifup/ifdown by default?
reopen 248071
reassign 248071 pcmcia-cs
severity 248071 wishlist
retitle 248071 Please make not calling ifup/ifdown the default for sarge
thanks
Per Olofsson wrote:
> Yes, you're probably right. I think the easiest way to implement this
> would be to add a variable to /etc/default/pcmcia and then make
> /etc/pcmcia/network.opts check it to determine whether to run
> ifup/ifdown or not.
Yes, that's a better way to do it.
> Any name suggestions? USE_IFUPDOWN? HOTPLUG_HANDLES_NETWORK?
The variable is not present on upgraded systems so the default had better
be to behave in the traditional way in the absence of the variable. That
makes 'USE_IFUPDOWN' less than ideal. Alternative control mechanisms
needn't be mentioned so that rules out 'HOTPLUG_HANDLES_NETWORK'.
I suggest 'DONT_IFUPDOWN' or something similar.
--- network.opts_ORIG 2004-05-16 19:51:13.000000000 +0200
+++ network.opts 2004-07-01 11:16:04.000000000 +0200
@@ -6,6 +6,9 @@
# See the Networking HOWTO. In short, the network address is the IP
# address masked by the netmask.
#
+
+[ -r /etc/default/pcmcia ] && . /etc/default/pcmcia
+
case "$ADDRESS" in
*,*,*,*)
INFO="Sample private network setup"
@@ -62,6 +65,7 @@
# if no settings are given higher up in this file. You can delete it
# if that isn't desired.
+is_true $DONT_IFUPDOWN || \
is_true $DHCLIENT || is_true $WHEREAMI || \
is_true $PUMP || is_true $BOOTP || is_true $DHCP || \
if [ -z "$IPADDR" ] && [ -x /sbin/ifup ] && [ -x /sbin/ifdown ] ; then
/etc/default/pcmcia is not a conffile so the installer can simply do:
cat <<EOF >> /etc/default/pcmcia
# Set DONT_IFUPDOWN to "yes" to inhibit cardmgr from running ifup and ifdown.
# In Debian sarge with the hotplug package installed it is not necessary
# for cardmgr to bring network interfaces up and down; the hotplug package
# does this for 16 bit PCMCIA cards as well as for CardBus and other cards.
DONT_IFUPDOWN=yes
EOF
> Then there is a second problem under 2.4 [...]
> This is, as you can see, very ugly and complicated, and I'm not very
> happy with it. If anybody knows a better way to detect Cardbus network
> cards under 2.4 kernels, please let me know.
All I can think of to suggest is that the user be given the opportunity
to override the installer's decisions about which interfaces to
classify as hotpluggable.
--
Thomas
Reply to: