[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#256954: marked as done (frees wrong memory)

Your message dated Wed, 30 Jun 2004 21:17:03 -0400
with message-id <E1BfqCF-000694-00@newraff.debian.org>
and subject line Bug#256954: fixed in cdebconf 0.67
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

Received: (at submit) by bugs.debian.org; 30 Jun 2004 04:40:21 +0000
>From kraai@ftbfs.org Tue Jun 29 21:40:20 2004
Return-path: <kraai@ftbfs.org>
Received: from zoon.lafn.org [] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BfWtQ-0001HP-00; Tue, 29 Jun 2004 21:40:20 -0700
Received: from localhost (host-66-81-16-28.rev.o1.com [])
	by zoon.lafn.org (8.12.3p3/8.11.3) with ESMTP id i5U4eIoH067254
	for <submit@bugs.debian.org>; Tue, 29 Jun 2004 21:40:19 -0700 (PDT)
	(envelope-from kraai@ftbfs.org)
Received: from kraai by localhost with local (Exim 4.32)
	id 1BfWrN-0000Xb-T0
	for submit@bugs.debian.org; Tue, 29 Jun 2004 21:38:13 -0700
Date: Tue, 29 Jun 2004 21:38:13 -0700
From: Matt Kraai <kraai@ftbfs.org>
To: submit@bugs.debian.org
Subject: frees wrong memory
Message-ID: <[🔎] 20040630043813.GA1301@catalunya>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="tKW2IUtsqtDRztdT"
Content-Disposition: inline
User-Agent: Mutt/1.5.6+20040523i
Sender: Matt Kraai <kraai@ftbfs.org>
X-Virus-Scanned: clamd / ClamAV version 0.70, clamav-milter version 0.70j
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25

Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Package: cdebconf
Version: 0.65
Severity: serious
Tags: patch

The first time ethdetect calls db_unregister, the read command
fails.  This prevents it from reading parameters, which prevents
it from loading the ne module, which prevents the network from
working, which prevents the installation from succeeding.

I think the read fails because the other end of the pipe closes
because cdebconf crashes because of a bug in
question_owner_delete: if the owner that it is trying to delete is
not last one in the list, it frees the owner field.

The attached, untested patch should fix it, but I'd appreciate a

Matt Kraai            kraai@ftbfs.org            http://ftbfs.org/

Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch

Index: packages/cdebconf/src/question.c
--- packages/cdebconf/src/question.c	(revision 17219)
+++ packages/cdebconf/src/question.c	(working copy)
@@ -122,25 +122,22 @@
 void question_owner_delete(struct question *q, const char *owner)
-	struct questionowner **ownerp, *nextp;
+	struct questionowner **ownerp;
-	for (ownerp = &q->owners; *ownerp != 0; ownerp = &(*ownerp)->next)
+	for (ownerp = &q->owners; *ownerp != 0;)
 		if (strcmp((*ownerp)->owner, owner) == 0)
-			nextp = (*ownerp)->next;
-			if (nextp == 0)
-			{
-				nextp = *ownerp;
-				*ownerp = 0;
-			}
-			else
-			{
-				**ownerp = *nextp;
-			}
-			DELETE(nextp->owner);
-			DELETE(nextp);
+			struct questionowner *currentp = *ownerp;
+			*ownerp = currentp->next;
+			DELETE(currentp->owner);
+			DELETE(currentp);
+		else
+		{
+			ownerp = &(*ownerp)->next;
+		}


Received: (at 256954-close) by bugs.debian.org; 1 Jul 2004 01:23:42 +0000
>From katie@ftp-master.debian.org Wed Jun 30 18:23:42 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BfqIg-0007vD-00; Wed, 30 Jun 2004 18:23:42 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BfqCF-000694-00; Wed, 30 Jun 2004 21:17:03 -0400
From: Matt Kraai <kraai@debian.org>
To: 256954-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#256954: fixed in cdebconf 0.67
Message-Id: <E1BfqCF-000694-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Wed, 30 Jun 2004 21:17:03 -0400
Delivered-To: 256954-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25

Source: cdebconf
Source-Version: 0.67

We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:

  to pool/main/c/cdebconf/cdebconf-newt-udeb_0.67_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-priority_0.67_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-text-udeb_0.67_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf-udeb_0.67_powerpc.udeb
  to pool/main/c/cdebconf/cdebconf_0.67.dsc
  to pool/main/c/cdebconf/cdebconf_0.67.tar.gz
  to pool/main/c/cdebconf/cdebconf_0.67_powerpc.deb
  to pool/main/c/cdebconf/libdebconfclient0-dev_0.67_powerpc.deb
  to pool/main/c/cdebconf/libdebconfclient0-udeb_0.67_powerpc.udeb
  to pool/main/c/cdebconf/libdebconfclient0_0.67_powerpc.deb

A summary of the changes between this version and the previous one is

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 256954@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
Matt Kraai <kraai@debian.org> (supplier of updated cdebconf package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)

Hash: SHA1

Format: 1.7
Date: Wed, 30 Jun 2004 17:37:37 -0700
Source: cdebconf
Binary: cdebconf-slang-udeb libdebconfclient0 cdebconf-priority cdebconf libdebconfclient0-dev cdebconf-udeb libdebconfclient0-udeb cdebconf-gtk-udeb cdebconf-text-udeb cdebconf-newt-udeb
Architecture: source powerpc
Version: 0.67
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Matt Kraai <kraai@debian.org>
 cdebconf   - Debian Configuration Management System (C-implementation)
 cdebconf-newt-udeb - Newt frontend for Debian Configuration Management System (udeb)
 cdebconf-priority - Change debconf priority (udeb)
 cdebconf-text-udeb - Plain text frontend for Debian Configuration Management System (udeb)
 cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
 libdebconfclient0 - Debian Configuration Management System (C-implementation)
 libdebconfclient0-dev - Development files for cdebconf
 libdebconfclient0-udeb - Debian Configuration Management System (C-implementation) (udeb)
Closes: 256954
 cdebconf (0.67) unstable; urgency=low
   * Matt Kraai
     - Free the owner field of the node being deleted (Closes: #256954).
     - Add self to Uploaders.
 db5422dac2f6df27179cdfcaaca16f4b 1054 utils - cdebconf_0.67.dsc
 75055f23865c43833cddbcb9f6c461a4 182532 utils - cdebconf_0.67.tar.gz
 6117a668fa51d7898f1c64fca306c2d2 34618 libdevel - libdebconfclient0-dev_0.67_powerpc.deb
 704a25bb3021a5d80b2d0871d74ccae5 22072 libs - libdebconfclient0_0.67_powerpc.deb
 e14f53f1b7a0fbdff51f7c08b30bd07c 116218 utils extra cdebconf_0.67_powerpc.deb
 7a9e90b520e1598eb89abf86862726eb 64780 debian-installer standard cdebconf-udeb_0.67_powerpc.udeb
 4a4ef18ec768125bf6665369af37447a 1940 debian-installer standard cdebconf-priority_0.67_powerpc.udeb
 32439f637c8edc1d03dc8bd55bf8b7cb 4956 debian-installer optional libdebconfclient0-udeb_0.67_powerpc.udeb
 ec034e56de172bdaaf96175f88d3ee52 12486 debian-installer optional cdebconf-newt-udeb_0.67_powerpc.udeb
 1a39e8d2b47e5f9b9d9fe8aeb5cf2ef6 15872 debian-installer optional cdebconf-text-udeb_0.67_powerpc.udeb
package-type: udeb

Version: GnuPG v1.2.4 (GNU/Linux)


Reply to: