[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: r16721 - trunk/packages/base-installer/debian



Martin Michlmayr wrote:
> * Joey Hess <joeyh@haydn.debian.org> [2004-06-09 12:18]:
> >     - Stop using df to find the /target partition (failed on 100 gb drives
> >       due to field width issues), and make the file system type be found in
> >       a way that is less prey to false positives.
> 
> I'm pretty sure other programs in d-i use df in this way too; so they
> have to be fixed too.

Yes, it's epidemic in the boot loader installers:

./arch/powerpc/yaboot-installer/debian/postinst:    df "/target$1" | sed '1d;s/[[:space:]].*//'
./arch/powerpc/quik-installer/debian/postinst:    df "/target$1" | sed '1d;s/ .*//'
./arch/alpha/aboot-installer/debian/postinst:realbootdev=`chroot /target df /boot \
./arch/alpha/aboot-installer/debian/postinst:rootdev=`chroot /target df / | sed -n -e'/^\/dev/ { s/[[:space:]].*//; p }'`
./arch/sparc/silo-installer/debian/silo-installer.postinst:     mapdevfs $(df /target$1 | sed '1d;s/ .*//')
./arch/i386/lilo-installer/debian/postinst:        df /target$1 | sed '1d;s/ .*//'
./arch/mipsel/colo-installer/debian/postinst:   df /target$1 | sed '1d;s/ .*//'
./arch/m68k/vmelilo-installer/debian/postinst:    df "/target$1" | sed '1d;s/[[:space:]].*//'

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: