[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#248106: busybox-cvs: sed broken on arm/powerpc/s390, assumes signed char



Package: busybox-cvs
Version: 20040507-1
Severity: grave

The latest busybox-cvs has this change in sed:

-       int opt, status = EXIT_SUCCESS;
+       char opt, getpat=1, status = EXIT_SUCCESS;

It then assigns the return value of int getopt() to opt. This is totally
broken on arm, powerpc, and s390, as char is unsigned there and getopt()
uses -1 as a sentinel value; sed now displays its usage message whenever
you try to do something as simple as "sed -e 's/.*//'". Please revert to
'int opt'.

Fortunately a quick browse of the diff suggests that this is the only
such breakage.

Thanks,

-- 
Colin Watson                                  [cjwatson@flatline.org.uk]



Reply to: