Re: Bug#234513: debian-installer: segfault when starting kbd-chooser
On Sat, Mar 13, 2004 at 09:10:12AM +0000, Alastair McKinstry wrote:
> Am Aoine, 2004-03-12 ag 23:46, scríobh Colin Watson:
> > The segfault is here, on line 627 of kbd-chooser.c in version 0.42:
> >
> > return (preferred->present == TRUE) ? "low" : "medium";
>
> > In addition to this, is it a bad sign that no preferred keyboard seems
> > to be found?
>
>
> Thanks for this. I've been having a hard time getting a powerpc setup to
> test this on.
>
> Mac keyboards were not being included in powerpc machines! Ok, now can
> we get this CVS version tested quickly for beta3?
Current CVS doesn't build:
cc -c -Wall -I. -DNDEBUG=1 -fomit-frame-pointer -Os -DUSB_KBD -DAT_KBD -DAMIGA_KBD +DMAC_KBD loadkeys.c
cc: +DMAC_KBD: No such file or directory
loadkeys.y: In function `addfunc':
loadkeys.y:609: warning: comparison is always false due to limited range of data type
loadkeys.y: At top level:
<stdout>:1593: warning: `yyunput' defined but not used
make[1]: *** [loadkeys.o] Error 1
Patch:
Index: Makefile
===================================================================
RCS file: /cvsroot/d-i/debian-installer/tools/kbd-chooser/Makefile,v
retrieving revision 1.24
diff -p -u -r1.24 Makefile
--- Makefile 13 Mar 2004 09:01:59 -0000 1.24
+++ Makefile 13 Mar 2004 10:28:23 -0000
@@ -45,7 +45,7 @@ CFLAGS += -DSPARC_KBD -DUSB_KBD
KEYBOARDS := sparc usb
endif
ifeq ($(ARCH),powerpc)
-CFLAGS += -DUSB_KBD -DAT_KBD -DAMIGA_KBD +DMAC_KBD
+CFLAGS += -DUSB_KBD -DAT_KBD -DAMIGA_KBD -DMAC_KBD
KEYBOARDS := at usb amiga mac
endif
ifeq ($(ARCH),arm)
After this, current CVS doesn't segfault, anyway, although as previously
mentioned I can't test in the d-i environment right now.
--
Colin Watson [cjwatson@flatline.org.uk]
Reply to: