[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#234130: choose-mirror: fails without proxy



Package: choose-mirror
Severity: important
Tags: patch

Hi,

choose-mirror fails if I don't select a proxy because busybox wget
doesn't handle an empty http_proxy variable (it has to be
undefined). I had to make the following change:

Index: retriever/choose-mirror/choose-mirror.c
===================================================================
RCS file: /cvsroot/d-i/debian-installer/retriever/choose-mirror/choose-mirror.c,v
retrieving revision 1.22
diff -u -r1.22 choose-mirror.c
--- retriever/choose-mirror/choose-mirror.c	19 Feb 2004 15:53:51 -0000	1.22
+++ retriever/choose-mirror/choose-mirror.c	21 Feb 2004 22:37:23 -0000
@@ -307,7 +307,7 @@
 		debconf_get(debconf, dir);
 		directory = strdup(debconf->value);
 	
-		if ( NULL == proxy )
+		if ( NULL == proxy || strlen(proxy) == 0 )
 			asprintf(&command, "wget -q %s://%s%s%s/Release -O - | grep ^Suite: | cut -d' ' -f 2",
 		                   protocol, hostname, directory,
 				   "dists/" PREFERRED_DISTRIBUTION);


-- 
Pelle



Reply to: