Bug#226722: marked as done (fails to create symlink)
Your message dated Thu, 08 Jan 2004 11:17:24 -0500
with message-id <E1Aecqa-0006Ed-00@auric.debian.org>
and subject line Bug#226722: fixed in busybox-cvs 20040101-2
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Jan 2004 02:14:26 +0000
>From kraai@lafn.org Wed Jan 07 20:14:09 2004
Return-path: <kraai@lafn.org>
Received: from zoot.lafn.org [206.117.18.6]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AeOxi-0002WB-00; Wed, 07 Jan 2004 19:27:50 -0600
Received: from catalunya (host-66-81-192-73.rev.o1.com [66.81.192.73])
by zoot.lafn.org (8.12.3p3/8.12.3) with ESMTP id i081RgIT015400
for <submit@bugs.debian.org>; Wed, 7 Jan 2004 17:27:45 -0800 (PST)
(envelope-from kraai@lafn.org)
Received: from kraai by catalunya with local (Exim 3.36 #1 (Debian))
id 1AeNGW-0000dW-00
for <submit@bugs.debian.org>; Wed, 07 Jan 2004 15:39:08 -0800
Date: Wed, 7 Jan 2004 15:39:08 -0800
From: Matt Kraai <kraai@ftbfs.org>
To: submit@bugs.debian.org
Subject: fails to create symlink
Message-ID: <[🔎] 20040107233908.GA349@catalunya>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="y0ulUmNC+osPPQO6"
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Sender: Matt Kraai <kraai@lafn.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin
2.60-master.debian.org_2003_11_25-bugs.debian.org_2004_1_5
(1.212-2003-09-23-exp) on master.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=HAS_PACKAGE autolearn=no
version=2.60-master.debian.org_2003_11_25-bugs.debian.org_2004_1_5
X-Spam-Level:
--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Package: busybox-cvs
Version: 20040101-1
Severity: grave
ln fails if the destination of the link does not exist relative to
the working directory. It should be interpreted relative to the
directory in which the link will be created, not relative to the
working directory.
This breaks debian-installer.
Here is a test case:
mkdir foo
touch foo/bar
ln -s bar foo/baz
A patch that fixes it is attached.
--
Matt Kraai kraai@ftbfs.org
--y0ulUmNC+osPPQO6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=patch
diff -ru busybox-cvs-20040101-old/coreutils/ln.c busybox-cvs-20040101/coreutils/ln.c
--- busybox-cvs-20040101-old/coreutils/ln.c 2004-01-07 14:52:51.000000000 -0800
+++ busybox-cvs-20040101/coreutils/ln.c 2004-01-07 15:35:36.000000000 -0800
@@ -62,6 +62,8 @@
}
do {
+ char *dest, *src_copy;
+
src_name = NULL;
src = last;
@@ -74,12 +76,16 @@
src_name = src;
}
- if (stat(*argv, &statbuf)) {
+ src_copy = bb_xstrdup(src);
+ dest = concat_path_file(dirname(src_copy), *argv);
+ if (stat(dest, &statbuf)) {
bb_perror_msg(*argv);
status = EXIT_FAILURE;
free(src_name);
continue;
}
+ free(src_copy);
+ free(dest);
if (flag & LN_FORCE) {
unlink(src);
--y0ulUmNC+osPPQO6--
---------------------------------------
Received: (at 226722-close) by bugs.debian.org; 8 Jan 2004 19:23:39 +0000
>From katie@auric.debian.org Thu Jan 08 13:23:39 2004
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1Aecr9-0004A4-00; Thu, 08 Jan 2004 10:17:59 -0600
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 1Aecqa-0006Ed-00; Thu, 08 Jan 2004 11:17:24 -0500
From: Bastian Blank <waldi@debian.org>
To: 226722-close@bugs.debian.org
X-Katie: $Revision: 1.43 $
Subject: Bug#226722: fixed in busybox-cvs 20040101-2
Message-Id: <E1Aecqa-0006Ed-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Thu, 08 Jan 2004 11:17:24 -0500
Delivered-To: 226722-close@bugs.debian.org
Source: busybox-cvs
Source-Version: 20040101-2
We believe that the bug you reported is fixed in the latest version of
busybox-cvs, which is due to be installed in the Debian FTP archive:
busybox-cvs-floppy-udeb_20040101-2_i386.udeb
to pool/main/b/busybox-cvs/busybox-cvs-floppy-udeb_20040101-2_i386.udeb
busybox-cvs-static_20040101-2_i386.deb
to pool/main/b/busybox-cvs/busybox-cvs-static_20040101-2_i386.deb
busybox-cvs-udeb_20040101-2_i386.udeb
to pool/main/b/busybox-cvs/busybox-cvs-udeb_20040101-2_i386.udeb
busybox-cvs_20040101-2.diff.gz
to pool/main/b/busybox-cvs/busybox-cvs_20040101-2.diff.gz
busybox-cvs_20040101-2.dsc
to pool/main/b/busybox-cvs/busybox-cvs_20040101-2.dsc
busybox-cvs_20040101-2_i386.deb
to pool/main/b/busybox-cvs/busybox-cvs_20040101-2_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 226722@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Bastian Blank <waldi@debian.org> (supplier of updated busybox-cvs package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Thu, 08 Jan 2004 12:50:27 +0100
Source: busybox-cvs
Binary: busybox-cvs-static busybox-cvs busybox-cvs-udeb busybox-cvs-floppy-udeb
Architecture: source i386
Version: 20040101-2
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Bastian Blank <waldi@debian.org>
Description:
busybox-cvs - Tiny utilities for small and embedded systems
busybox-cvs-floppy-udeb - Tiny utilities for the debian-installer floppy images (udeb)
busybox-cvs-static - Standalone rescue shell with tons of builtin utilities
busybox-cvs-udeb - Tiny utilities for the debian-installer (udeb)
Closes: 226722
Changes:
busybox-cvs (20040101-2) unstable; urgency=low
.
* coreutils/ln.c:
- Fix check in symlink mode (upstream). (closes: #226722)
Files:
1fd9cab65e3154d5a063b40e583a57ac 826 - optional busybox-cvs_20040101-2.dsc
f8b7b39a0a93a24b796a1ddafd031812 140413 - optional busybox-cvs_20040101-2.diff.gz
f03e8c10b99fac60416ea76051cb70c5 663798 shells optional busybox-cvs-static_20040101-2_i386.deb
44a2b38578052f442e42965f1a4020d0 124968 utils optional busybox-cvs_20040101-2_i386.deb
ab03ff66d855ae300ec95f96fd3d83ca 134724 debian-installer extra busybox-cvs-udeb_20040101-2_i386.udeb
8e1629dc5943a443f0d4d666551263de 59182 debian-installer extra busybox-cvs-floppy-udeb_20040101-2_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iEYEARECAAYFAj/9f+UACgkQLkAIIn9ODhGViACeNgvUYfufXrCxf7WKy+vtKAoT
UwUAnjp7ljX1cVhVfVNzi03HjCICM/mq
=6LVX
-----END PGP SIGNATURE-----
Reply to: