On Wed, Dec 17, 2003 at 12:59:36PM +0100, Marco d'Itri wrote:
> This patch adds preliminar support for .ko kernel modules.
> Please apply.
Read on.
>
> --
> ciao, |
> Marco | [3654 coOaZqA3WDJk2]
> diff -ur ORIG.debian-installer/build/Makefile debian-installer/build/Makefile
> --- ORIG.debian-installer/build/Makefile 2003-12-14 17:19:16.000000000 +0100
<snip/>
> - `if [ -d "$(DRIVEREXTRASDIR)" ]; then find $(DRIVEREXTRASDIR)/lib/modules -name \*.o; fi` \
> - `find $(TREE)/lib/modules/ -name \*.o` > \
> + `if [ -d "$(DRIVEREXTRASDIR)" ]; then find $(DRIVEREXTRASDIR)/lib/modules -name \*.o -name \*.ko; fi` \
> + `find $(TREE)/lib/modules/ -name \*.o -name \*.ko` > \
This will break the current system.
From the find manual page:
find searches the
directory tree rooted at each given file name by evaluating the given
expression from left to right, according to the rules of precedence
(see section OPERATORS), until the outcome is known (the left hand side
is false for and operations, true for or), at which point find moves on
to the next file name.
The _and_ _or_ stuff is important. Take look at this example:
# mkdir kanweg
mir-CHROOT:~
# cd !$
cd kanweg
mir-CHROOT:~/kanweg
# mkdir a b c
mir-CHROOT:~/kanweg
# touch a/a.o a/a.ko b/b.o b/b. b/b.ko c/c.o
mir-CHROOT:~/kanweg
# find . -name *.o
./a/a.o
./b/b.o
./c/c.o
mir-CHROOT:~/kanweg
# find . -name *.o -name *.ko
mir-CHROOT:~/kanweg
# find . -name *.o -o -name *.ko
./a/a.o
./a/a.ko
./b/b.o
./b/b.ko
./c/c.o
mir-CHROOT:~/kanweg
#
This means that there was time spent on the patch, but it is rejected.
You are welcome to send an other one.
Geert Stappers
Attachment:
pgpESKhtKzMbi.pgp
Description: PGP signature