[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#218992: base-installer: Debconf templates polishing



Package: base-installer
Severity: normal
Tags: patch

Yet another polishing bug report..:-)

Detailed explanations:

--- base-installer.ori/debian/base-installer.templates	2003-11-03 18:40:03.000000000 +0100
+++ base-installer/debian/base-installer.templates	2003-11-03 18:53:44.000000000 +0100
@@ -1,22 +1,24 @@
 Template: base-installer/debootstrap-failed
-Type: note
-_Description: Installing base system into /target/ failed
- Check /target/var/log/debootstrap.log and
+Type: error
+_Description: Failed to install the base system
+ The base system installation into /target/ failed.
+ .
+ Please check /target/var/log/debootstrap.log and
  /target/var/log/debootstrap.err.log for the details.

1) this is an error, afaik
2) more consistency with several other error templates
3) Be polite..:)

 Template: base-installer/debootstrap/error-exitcode
-Type: note
-_Description: Base installation error
- debootstrap exited with an error (return value ${EXITCODE}).
+Type: error
+_Description: Base system installation error
+ The debootstrap program exited with an error (return value ${EXITCODE}).
  .
- You might find more information in /target/var/log/debootstrap.log
+ You might find more information in /target/var/log/debootstrap.log.

1) error
2) I think the word "system" is needed here
3) Dot at the end of the phrase : no-one with enough skills for knowing how
   to read a file during installation process will think this dot is part of
   the file name


 Template: base-installer/debootstrap/error-abnormal
-Type: note
-_Description: Base installation error
- debootstrap exited abnormally.
+Type: error
+_Description: Base system installation error
+ The debootstrap program exited abnormally.
  .
- You might find more information in /target/var/log/debootstrap.log
+ You might find more information in /target/var/log/debootstrap.log.

1) ditto
2) ditto
3) It's worth mentioning *what* is debootstrap....


 Template: base-installer/debootstrap/progress/downrel
 Type: text
-_Description: Retrieving Release file
+_Description: Retrieving Release file...

As well as all following templates which are progress templates...just for
consistency and informing the user that some lengthy operation occurs (even
if it takes 0.03 secs...).

 Template: base-installer/debootstrap/info/basesuccess
 Type: note
-_Description: Base system installed successfully.
+_Description: Base system successfully installed
 
Ending dot removed (title). Looks better to me : is it?


diff -Nru base-installer.ori/debian/kernel-installer.templates base-installer/debian/kernel-installer.templates
--- base-installer.ori/debian/kernel-installer.templates	2003-11-03 18:40:03.000000000 +0100
+++ base-installer/debian/kernel-installer.templates	2003-11-03 18:45:48.000000000 +0100
@@ -1,9 +1,9 @@
 Template: kernel-installer/no-kernel
 Type: error
-_Description: No kernel package is selected for installation
- Unable to install a kernel.
+_Description: Unable to install a kernel
+ No kernel package is selected for installation.
  .
- You might try to select "Install the kernel" again on the main
+ You might try to select the kernel installation step again on the main
  menu. That will allow you to select another kernel to install.

The short description is a title so let's have it look like a title. The
original sentence goes into extended description.

I suggest avoiding to refer to the exact main-menu steps in templates, just
for preventing us to forget updating everything if we manage to change a
main menu entry.


 Template: kernel-installer/failed-install
@@ -16,24 +16,24 @@
  .
  This is probably a fatal error.
  .
- You might try to select "Install the kernel" again on the main
+ You might try to select the kernel installation step again on the main
  menu. That will allow you to select another kernel to install.

Ditto.

 Template: kernel-installer/which-kernel
 Type: select
 Choices: ${KERNELS}
-_Description: Select which kernel to install into /target/
- These are the kernels available from the APT sources.  One of them
- needs to be installed to be able to boot the system from hard drive.
+_Description: Kernel to install into /target/:
+ The list shows the kernels available from the APT sources.  Please choose
+ one of them in order to make to system bootable from the hard drive.

Consistency with the Style Guide document. Maybe better english is possible?

 Template: kernel-installer/no-kernels-found
 Type: error
-_Description: No installable kernel was found in the APT sources defined
- This is rather strange, and probably fatal.
+_Description: No installable kernel found
+ No installable kernel was found in the defined APT sources.
  .
  The current default kernel package is '${KERNEL}'.
  .
- You will have to continue as best as you can.  Good luck.
+ You may try to continue though this rather strange error is probably fatal.

1) short desc : we have to keep it short. The current phrase is impossible
to translate shortly in french, for instance.

2) The "good luck" thing sounds odd to me. 

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux mykerinos 2.4.22 #2 Mon Sep 29 15:12:10 CEST 2003 i686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (ignored: LC_ALL set to fr_FR.UTF-8)

diff -Nru base-installer.ori/debian/base-installer.templates base-installer/debian/base-installer.templates
--- base-installer.ori/debian/base-installer.templates	2003-11-03 18:40:03.000000000 +0100
+++ base-installer/debian/base-installer.templates	2003-11-03 18:53:44.000000000 +0100
@@ -1,22 +1,24 @@
 Template: base-installer/debootstrap-failed
-Type: note
-_Description: Installing base system into /target/ failed
- Check /target/var/log/debootstrap.log and
+Type: error
+_Description: Failed to install the base system
+ The base system installation into /target/ failed.
+ .
+ Please check /target/var/log/debootstrap.log and
  /target/var/log/debootstrap.err.log for the details.
 
 Template: base-installer/debootstrap/error-exitcode
-Type: note
-_Description: Base installation error
- debootstrap exited with an error (return value ${EXITCODE}).
+Type: error
+_Description: Base system installation error
+ The debootstrap program exited with an error (return value ${EXITCODE}).
  .
- You might find more information in /target/var/log/debootstrap.log
+ You might find more information in /target/var/log/debootstrap.log.
 
 Template: base-installer/debootstrap/error-abnormal
-Type: note
-_Description: Base installation error
- debootstrap exited abnormally.
+Type: error
+_Description: Base system installation error
+ The debootstrap program exited abnormally.
  .
- You might find more information in /target/var/log/debootstrap.log
+ You might find more information in /target/var/log/debootstrap.log.
 
 Template: base-installer/debootstrap/fallback-error
 Type: error
@@ -26,7 +28,7 @@
  ${ERROR}
  .
  You might find more information in /target/var/log/debootstrap.log
- or /target/var/log/debootstrap.err.log
+ or /target/var/log/debootstrap.err.log.
 
 Template: base-installer/debootstrap/error/baddload
 Type: error
@@ -89,43 +91,43 @@
 
 Template: base-installer/debootstrap/progress/downrel
 Type: text
-_Description: Retrieving Release file
+_Description: Retrieving Release file...
 
 Template: base-installer/debootstrap/progress/downpkgs
 Type: text
-_Description: Retrieving Packages files
+_Description: Retrieving Packages files...
 
 Template: base-installer/debootstrap/progress/downdebs
 Type: text
-_Description: Retrieving packages
+_Description: Retrieving packages...
 
 Template: base-installer/debootstrap/progress/downmainpkgs
 Type: text
-_Description: Retrieving Packages file
+_Description: Retrieving Packages file...
 
 Template: base-installer/debootstrap/progress/extractpkgs
 Type: text
-_Description: Extracting packages
+_Description: Extracting packages...
 
 Template: base-installer/debootstrap/progress/instbase
 Type: text
-_Description: Installing base system
+_Description: Installing base system...
 
 Template: base-installer/debootstrap/fallback-info
 Type: text
-Description: ${INFO}
+Description: ${INFO}...
 
 Template: base-installer/debootstrap/info/validating
 Type: text
-_Description: Validating ${SUBST0}
+_Description: Validating ${SUBST0}...
 
 Template: base-installer/debootstrap/info/retrieving
 Type: text
-_Description: Retrieving ${SUBST0}
+_Description: Retrieving ${SUBST0}...
 
 Template: base-installer/debootstrap/info/extracting
 Type: text
-_Description: Extracting ${SUBST0}
+_Description: Extracting ${SUBST0}...
 
 Template: base-installer/debootstrap/info/instcore
 Type: text
@@ -145,7 +147,7 @@
 
 Template: base-installer/debootstrap/info/basesuccess
 Type: note
-_Description: Base system installed successfully.
+_Description: Base system successfully installed
 
 Template: base-installer/apt/progress/title
 Type: text
@@ -153,15 +155,15 @@
 
 Template: base-installer/apt/progress/step_config
 Type: text
-_Description: Configuring APT sources
+_Description: Configuring APT sources...
 
 Template: base-installer/apt/progress/step_update
 Type: text
-_Description: Updating the list of available packages
+_Description: Updating the list of available packages...
 
 Template: base-installer/apt/progress/step_install
 Type: text
-_Description: Installing the extra packages
+_Description: Installing the extra packages...
 
 Template: debian-installer/base-installer/title
 Type: text

diff -Nru base-installer.ori/debian/kernel-installer.templates base-installer/debian/kernel-installer.templates
--- base-installer.ori/debian/kernel-installer.templates	2003-11-03 18:40:03.000000000 +0100
+++ base-installer/debian/kernel-installer.templates	2003-11-03 18:45:48.000000000 +0100
@@ -1,9 +1,9 @@
 Template: kernel-installer/no-kernel
 Type: error
-_Description: No kernel package is selected for installation
- Unable to install a kernel.
+_Description: Unable to install a kernel
+ No kernel package is selected for installation.
  .
- You might try to select "Install the kernel" again on the main
+ You might try to select the kernel installation step again on the main
  menu. That will allow you to select another kernel to install.
 
 Template: kernel-installer/failed-install
@@ -16,24 +16,24 @@
  .
  This is probably a fatal error.
  .
- You might try to select "Install the kernel" again on the main
+ You might try to select the kernel installation step again on the main
  menu. That will allow you to select another kernel to install.
 
 Template: kernel-installer/which-kernel
 Type: select
 Choices: ${KERNELS}
-_Description: Select which kernel to install into /target/
- These are the kernels available from the APT sources.  One of them
- needs to be installed to be able to boot the system from hard drive.
+_Description: Kernel to install into /target/:
+ The list shows the kernels available from the APT sources.  Please choose
+ one of them in order to make to system bootable from the hard drive.
 
 Template: kernel-installer/no-kernels-found
 Type: error
-_Description: No installable kernel was found in the APT sources defined
- This is rather strange, and probably fatal.
+_Description: No installable kernel found
+ No installable kernel was found in the defined APT sources.
  .
  The current default kernel package is '${KERNEL}'.
  .
- You will have to continue as best as you can.  Good luck.
+ You may try to continue though this rather strange error is probably fatal.
 
 Template: kernel-installer/progress/title
 Type: text

Reply to: