anna: Isn't this code buggy?

[Goswin von Brederlow <brederlo@informatik.uni-tuebingen.de>]

Hi,

util.c 330: Warning: match might be used uninitialized in this
function

----------------------------------------------------------------------
int
new_retrievers(di_package **retrievers_before, di_package **retrievers_after)
{
    int i, j;
    int match;

    for (i = 0; retrievers_before[i]; i++)
	match = 0;
	for (j = 0; retrievers_after[i]; i++)
	    if (strcmp(retrievers_before[i]->package,
                       retrievers_after[j]->package) == 0) {
		match = 1;
		break;
	    }
	if (!match)
	    return 1;
    return 0;
}
----------------------------------------------------------------------

I notice two things:

1. The indentation suggests a missing {} for the first loop
2. The second loop might want to test "retrievers_after[j]"

MfG
        Goswin