[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#211063: marked as done (autopartkit: should not re-ask for confirmation)



Your message dated Mon, 22 Sep 2003 17:02:15 -0400
with message-id <E1A1Xp1-0003dE-00@auric.debian.org>
and subject line Bug#211063: fixed in autopartkit 0.58
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Sep 2003 16:14:16 +0000
>From sesse@dessverre.samfundet.no Mon Sep 15 11:14:14 2003
Return-path: <sesse@dessverre.samfundet.no>
Received: from dessverre.samfundet.no [129.241.93.53] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 19yvzR-0000e4-00; Mon, 15 Sep 2003 11:14:13 -0500
Received: from sesse by dessverre.samfundet.no with local (Exim 3.36 #1 (Debian))
	id 19yvzE-0001N6-00; Mon, 15 Sep 2003 18:14:00 +0200
Content-Type: multipart/mixed; boundary="===============1864829871=="
MIME-Version: 1.0
From: "Steinar H. Gunderson" <sgunderson@bigfoot.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: autopartkit: should not re-ask for confirmation
X-Mailer: reportbug 2.28
Date: Mon, 15 Sep 2003 18:14:00 +0200
Message-Id: <E19yvzE-0001N6-00@dessverre.samfundet.no>
Sender: "Steinar H. Gunderson" <sesse@dessverre.samfundet.no>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-11.3 required=4.0
	tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF
	autolearn=ham version=2.53-bugs.debian.org_2003_9_14
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_9_14 (1.174.2.15-2003-03-30-exp)

This is a multi-part MIME message sent by reportbug.

--===============1864829871==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Package: autopartkit
Version: 0.57 (not installed)
Severity: wishlist
Tags: patch d-i

Before asking autopartkit/confirm (the message that asks the user to
confirm the deletion of everything on all hard drives), autopartkit
fsets autopartkit/confirm's "seen" attribute to false, which prevents
(among others) fully automated installation.

The included (untested) patch makes autopartkit heed the "seen"
attribute, but sets it back to false if the user answered no or exited,
since the user usually would go back and correct something, and then
answer yes the second time.

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux dessverre 2.4.20-k7 #1 Tue Jan 14 00:29:06 EST 2003 i686
Locale: LANG=C, LC_CTYPE=en_US.ISO8859-1


--===============1864829871==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="/root/debian-installer/tools/autopartkit/autopartkit-confirm-onlyonce.patch"

? autopartkit-confirm-onlyonce.patch
Index: autopartkit.c
===================================================================
RCS file: /cvs/debian-boot/debian-installer/tools/autopartkit/autopartkit.c,v
retrieving revision 1.63
diff -u -r1.63 autopartkit.c
--- autopartkit.c	16 Aug 2003 22:57:46 -0000	1.63
+++ autopartkit.c	15 Sep 2003 16:10:49 -0000
@@ -205,19 +205,6 @@
     client->command(client, "TITLE", new_title, NULL);
 }
 
-static int mydebconf_bool(char *priority, char *template)
-{
-    const char *value;
-
-    value = mydebconf_input(priority, template);
-    if (strstr(value, "true"))
-	return 1;
-    if (strstr(value, "false"))
-	return 0;
-    mydebconf_debug("unknown bool value", value);
-    return 0;
-}
-
 void autopartkit_log(const int level, const char * format, ...)
 {
     int LOGLIMIT = 1;
@@ -228,18 +215,23 @@
     vsyslog(LOG_DEBUG, format, ap);
     va_end(ap);
 }
+
+/* note: only fsets seen=true if the user answered yes */
 static void autopartkit_confirm(void)
 {
-    static int confirm = 0;
-    if (confirm)
-	return;
-    if (mydebconf_bool("critical", "autopartkit/confirm"))
-    {
-	confirm = 1;
-	return;
-    } else {
-	exit(EXIT_FAILURE);
-    }
+    client->command (client, "INPUT", "critical", "autopartkit/confirm", NULL);
+    client->command (client, "GO", NULL);
+    client->command (client, "GET", "autopartkit/confirm", NULL);
+
+    if (strstr(client->value, "true"))
+        return;
+
+    client->command (client, "FSET", "autopartkit/confirm", "seen", "false", NULL);
+    
+    if (strstr(client->value, "false"))
+        exit(EXIT_FAILURE);
+    mydebconf_debug("unknown bool value", client->value);
+    exit(EXIT_FAILURE);
 }
 
 static void disable_kmsg(int disable)

--===============1864829871==--

---------------------------------------
Received: (at 211063-close) by bugs.debian.org; 22 Sep 2003 21:08:18 +0000
>From katie@auric.debian.org Mon Sep 22 16:08:14 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] 
	by master.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1A1Xuk-00006b-00; Mon, 22 Sep 2003 16:08:10 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 1A1Xp1-0003dE-00; Mon, 22 Sep 2003 17:02:15 -0400
From: Petter Reinholdtsen <pere@debian.org>
To: 211063-close@bugs.debian.org
X-Katie: $Revision: 1.37 $
Subject: Bug#211063: fixed in autopartkit 0.58
Message-Id: <E1A1Xp1-0003dE-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Mon, 22 Sep 2003 17:02:15 -0400
Delivered-To: 211063-close@bugs.debian.org

Source: autopartkit
Source-Version: 0.58

We believe that the bug you reported is fixed in the latest version of
autopartkit, which is due to be installed in the Debian FTP archive:

autopartkit_0.58.dsc
  to pool/main/a/autopartkit/autopartkit_0.58.dsc
autopartkit_0.58.tar.gz
  to pool/main/a/autopartkit/autopartkit_0.58.tar.gz
autopartkit_0.58_i386.udeb
  to pool/main/a/autopartkit/autopartkit_0.58_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 211063@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated autopartkit package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 22 Sep 2003 22:56:33 +0200
Source: autopartkit
Binary: autopartkit
Architecture: source i386
Version: 0.58
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 autopartkit - Automatically Partition Hard Drives (unsafe) (udeb)
Closes: 211063 211243
Changes: 
 autopartkit (0.58) unstable; urgency=low
 .
   * Chris Tillman
     - Update English usage in message templates
   * Steinar H. Gunderson
     - Fixed package description to match package behaviour better (destroys
       all partitions, does not resize them). (Closes: #211243)
     - Add support for expressions in template files, making stuff like
       "($RAMSIZE*1.5)+16" for max/min sizes possible. The default template
       file now also utilizes this.
     - Improve handling of the confirmation message, to smooth out unattended
       installations. It is now possible to do the confirmation beforehand via
       debconf for fully automated installation, but autopartkit should still
       behave reasonably in the normal case. (Closes: #211063)
   * Jordi Mallach
     - Added Catalan (ca) translation.
   * Pierre Machard
     - Update French po-debconf translation thanks to [Christian Perrier]
   * Kenshi Muto
     - Update ja.po
   * Petter Reinholdtsen
     - Rewrite confirm code to avoid trying to duplicate the "seen"
       handling in cdebconf.
     - Reduce binary size by using string constants for debconf
       template names.
     - Update nb.po.
Files: 
 0654f22e1a4e8f44cae251ff6ff2f1bd 675 debian-installer standard autopartkit_0.58.dsc
 e274cbbd6efc5d6083c4d4e25f2f3f33 135023 debian-installer standard autopartkit_0.58.tar.gz
 1d93bc713d9d051d4821b5aebd0db860 25278 debian-installer standard autopartkit_0.58_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.3 (GNU/Linux)

iD8DBQE/b2Ip20zMSyow1ykRAv/CAJ9CPR1SZEHswQAXDyl1zHnCHT2gAgCeLDU4
SDB1S4j2PyaNoLNXCvTDHZI=
=Fzl0
-----END PGP SIGNATURE-----



Reply to: