[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#212485: busybox-cvs-udeb: typo in build scripts prevent busybox from being built with optimization



Package: busybox-cvs-udeb
Version: 0.60.99.cvs20030819-3 (not installed)
Severity: important
Tags: patch d-i upstream

A typo (OPTIMIZATION is used some places and OPTIMIZATIONS others)
prevent busybox-cvs-udeb from being built with optimization (only
-fomit-frame-pointer is activated, no -O option at all). This wastes
16kB in the udeb (more uncompressed), which should hopefully be enough
to get the d-i floppies under the size limit again. Please apply the
attached patch.

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux dessverre 2.4.22-1-k7 #1 Sat Sep 6 02:13:04 EST 2003 i686
Locale: LANG=C, LC_CTYPE=C

diff -ur busybox-cvs-0.60.99.cvs20030819/Rules.mak.in busybox-cvs-patched/Rules.mak.in
--- busybox-cvs-0.60.99.cvs20030819/Rules.mak.in	2003-09-17 23:15:05.000000000 +0200
+++ busybox-cvs-patched/Rules.mak.in	2003-09-24 00:47:03.000000000 +0200
@@ -99,7 +99,7 @@
 	OPTIMIZATION += -mpreferred-stack-boundary=2
 	OPTIMIZATION += -falign-functions=0 -falign-jumps=0 -falign-loops=0
 endif
-OPTIMIZATIONS += -fomit-frame-pointer
+OPTIMIZATION += -fomit-frame-pointer
 
 #
 #--------------------------------------------------------
@@ -131,7 +131,7 @@
     LDFLAGS +=-Wl,-warn-common
     STRIPCMD:=/bin/true -Not_stripping_since_we_are_debugging
 else
-    CFLAGS+=$(WARNINGS) $(OPTIMIZATIONS) -DNDEBUG
+    CFLAGS+=$(WARNINGS) $(OPTIMIZATION) -DNDEBUG
     LDFLAGS += -s -Wl,-warn-common
     STRIPCMD:=$(STRIP) --remove-section=.note --remove-section=.comment
 endif


Reply to: