[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#206056: boot-floppies: [patch] Iyonix support and ARM fixes



On Mon, 2003-08-18 at 13:31, Peter Naulls wrote:
>      mips/*|arm/*)
> -	cp $extractdir/boot/vmlinux-* linux$subarch.bin
> +	cp $extractdir/boot/vmlinu*-* linux$subarch.bin

I don't like this change very much.  Can you coordinate with Othmar and
figure out what the right answer is?  Maybe it needs to be keyed on
subarch, or something.

>  #elif #cpu(arm)
> -      if (!strcmp(Arch2, "netwinder"))
> +//      if (!strcmp(Arch2, "netwinder"))
>  	/* UGLY UGLY UGLY */

Please don't leave code commented out like this, especially not "if"
statements.  If the line is wrong, just delete it.

The rest of your changes look fine.  Unless Vince has any objections, I
will check them in.

p.




Reply to: