[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#191588: marked as done (lilo-installer should use the last console arg on the cmdline)



Your message dated Sat, 10 May 2003 16:17:43 -0400
with message-id <E19Eamt-0003b2-00@auric.debian.org>
and subject line Bug#191588: fixed in lilo-installer 0.0.13
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 1 May 2003 23:34:37 +0000
>From joe@nahmias.net Thu May 01 18:34:35 2003
Return-path: <joe@nahmias.net>
Received: from user-0ccerf2.cable.mindspring.com (a750.nahmias.net) [24.199.109.226] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 19BNZT-0007us-00; Thu, 01 May 2003 18:34:35 -0500
Received: by a750.nahmias.net (Postfix, from userid 1000)
	id 7A6F0E80D; Thu,  1 May 2003 19:34:03 -0400 (EDT)
From: Joe Nahmias <joe@nahmias.net>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: lilo-installer should use the last console arg on the cmdline
X-Mailer: reportbug 1.50
Date: Thu, 01 May 2003 19:33:51 -0400
Message-Id: <[🔎] 20030501233403.7A6F0E80D@a750.nahmias.net>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-11.7 required=4.0
	tests=BAYES_01,HAS_PACKAGE,PGP_SIGNATURE
	autolearn=ham version=2.53-bugs.debian.org_2003_04_23
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_04_23 (1.174.2.15-2003-03-30-exp)

Package: lilo-installer
Version: 0.0.11; reported 2003-05-01
Severity: normal
Tags: patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The linux kernel can be passed multiple "console=" arguments on the
command line.  This results in the _last_ one specified being used as
the default.  lilo-installer uses the _first_ one when trying to
determine whether to configure lilo for a serial console.

Also, lilo-installer should emit some sort of message when configuring
lilo to use a serial console to prevent suprises.

The following patch addresses these issues.

Joe Nahmias, DD wannabe


- --- debian/lilo-installer.postinst.orig	2003-02-22 11:54:18.000000000 -0500
+++ debian/lilo-installer.postinst	2003-05-01 19:20:23.000000000 -0400
@@ -41,12 +41,13 @@ fi
 bootdev=`mapdevfs $bootdev`
 rootfs=`mapdevfs $rootfs`
 
- -# serial support
- -
- -if grep -q console=ttyS /proc/cmdline; then
- -    PORT=$(sed -e 's%.*console=ttyS%%' -e 's%,.*%%' /proc/cmdline)
- -    SPEED=$(sed -e 's%.*console=ttyS[0-9]\+,%%' -e 's% .*%%' /proc/cmdline)
+# Use a serial console if current default console is a serial port.
+defconsole=$(sed -e 's/.*console=/console=/')	# default console is last listed
+if echo "${defconsole}" | grep -q console=ttyS; then
+    PORT=$(echo "${defconsole}" | sed -e 's%^console=ttyS%%' -e 's%,.*%%')
+    SPEED=$(echo "${defconsole}" | sed -e 's%^console=ttyS[0-9]\+,%%' -e 's% .*%%')
     SERIAL="${PORT},${SPEED}"
+    echo "Configuring lilo to use serial port ttyS${PORT} as the console."
 fi
 
 #write out lilo.conf


- -- System Information
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux a750.nahmias.net 2.4.20 #1 Thu Jan 9 11:22:09 EST 2003 i686
Locale: LANG=C, LC_CTYPE=C

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE+sa7rKl23+OYWEqURAjwAAJ4oGil8w4cTIpA5Bq8V4tTqXyuJ9wCdEiex
J/44XLrVeeGAv13VKu7vGCs=
=4JHK
-----END PGP SIGNATURE-----

---------------------------------------
Received: (at 191588-close) by bugs.debian.org; 10 May 2003 20:23:06 +0000
>From katie@auric.debian.org Sat May 10 15:23:05 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] (mail)
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 19Eas5-00066t-00; Sat, 10 May 2003 15:23:05 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
	id 19Eamt-0003b2-00; Sat, 10 May 2003 16:17:43 -0400
From: Petter Reinholdtsen <pere@debian.org>
To: 191588-close@bugs.debian.org
X-Katie: $Revision: 1.34 $
Subject: Bug#191588: fixed in lilo-installer 0.0.13
Message-Id: <E19Eamt-0003b2-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Sat, 10 May 2003 16:17:43 -0400
Delivered-To: 191588-close@bugs.debian.org

We believe that the bug you reported is fixed in the latest version of
lilo-installer, which is due to be installed in the Debian FTP archive:

lilo-installer_0.0.13.dsc
  to pool/main/l/lilo-installer/lilo-installer_0.0.13.dsc
lilo-installer_0.0.13.tar.gz
  to pool/main/l/lilo-installer/lilo-installer_0.0.13.tar.gz
lilo-installer_0.0.13_i386.udeb
  to pool/main/l/lilo-installer/lilo-installer_0.0.13_i386.udeb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 191588@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Petter Reinholdtsen <pere@debian.org> (supplier of updated lilo-installer package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 10 May 2003 22:06:31 +0200
Source: lilo-installer
Binary: lilo-installer
Architecture: source i386
Version: 0.0.13
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Petter Reinholdtsen <pere@debian.org>
Description: 
 lilo-installer - Install LILO on a hard disk (udeb)
Closes: 84287 191588
Changes: 
 lilo-installer (0.0.13) unstable; urgency=low
 .
   * Make it possible to build this package using binary-arch target.
     (Closes: 84287)
   * Correct call do db_input, it should only ignore return value 30
     meaning the question was not displayed.  All other return values
     are errors.
   * Add myself as uploader for this package.
   * Make sure to use the same default console as the linux kernel, and
     let the user know when a serial console is enabled.  Based on patch
     from Joe Nahmias.  (Closes: #191588)
   * André Luís Lopes :
     - Update pt_BR debconf template translation.
Files: 
 260924b3b47f0970ffcda6b1e452ed40 680 debian-installer standard lilo-installer_0.0.13.dsc
 6e26ac8750ee0d7b1da7849ea1eea20d 7577 debian-installer standard lilo-installer_0.0.13.tar.gz
 03e466732d6a459dd7cbe95f74f72701 2912 debian-installer standard lilo-installer_0.0.13_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE+vVvw20zMSyow1ykRArMQAJ9qhPeBcyZCIsGY7yH/Fij7Wf+4rQCeOTWE
SdGDI7JBHfEXVhVRM3QDTAQ=
=mYSw
-----END PGP SIGNATURE-----



Reply to: