Bug#181088: marked as done (Progress bar API problem)
Your message dated Fri, 21 Feb 2003 18:32:10 -0500
with message-id <E18mMeI-0007pp-00@auric.debian.org>
and subject line Bug#181088: fixed in cdebconf 0.31
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 15 Feb 2003 10:37:29 +0000
>From md9ms@mdstud.chalmers.se Sat Feb 15 04:37:28 2003
Return-path: <md9ms@mdstud.chalmers.se>
Received: from smtp.gu.se [130.241.150.66]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18jzhI-00079l-00; Sat, 15 Feb 2003 04:37:28 -0600
Received: from sjogren.ostkupan.studenthem.gu.se (sjogren.ostkupan.studenthem.gu.se [193.11.232.159])
by smtp.gu.se (8.12.5/8.12.5) with ESMTP id h1FAbQXO026556
for <submit@bugs.debian.org>; Sat, 15 Feb 2003 11:37:26 +0100
Subject: Progress bar API problem
From: Martin =?ISO-8859-1?Q?Sj=F6gren?= <md9ms@mdstud.chalmers.se>
To: submit@bugs.debian.org
In-Reply-To: <[🔎] 1045303389.1951.3.camel@sjogren.ostkupan.studenthem.gu.se>
References: <[🔎] 1045303389.1951.3.camel@sjogren.ostkupan.studenthem.gu.se>
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-UMLPC8eCUBwuWxurf2A0"
Organization:
Message-Id: <[🔎] 1045305446.1957.11.camel@sjogren.ostkupan.studenthem.gu.se>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.1
Date: 15 Feb 2003 11:37:26 +0100
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-3.9 required=4.0
tests=HAS_PACKAGE,IN_REP_TO,PATCH_UNIFIED_DIFF,PGP_SIGNATURE_2,
QUOTED_EMAIL_TEXT,REFERENCES,SPAM_PHRASE_00_01
version=2.44
X-Spam-Level:
--=-UMLPC8eCUBwuWxurf2A0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Package: cdebconf
Version: 0.30
Severity: wishlist
Tags: patch
l=F6r 2003-02-15 klockan 11.03 skrev Martin Sj=F6gren:
> The typical use of the progress bar API looks like this:
>=20
>=20
> PROGRESS START 0 N foo/start
>=20
> PROGRESS STEP 1 foo/inc
> ...
> PROGRESS STEP 1 foo/inc
> ...
> (et.c.)
>=20
> PROGRESS STOP
>=20
>=20
> Now, the problem is that the counter is increased before the text is
> displayed. Wouldn't it make more sense to do a post-increment than a
> pre-increment? I guess that would mean that PROGRESS STOP has to show
> the final 100% value before leaving.
>=20
> How does that sound?
Here's one (somewhat hackish) way to do it:
diff -u -r1.31 text.c
--- src/modules/frontend/text/text.c 26 Jan 2003 16:51:54 -0000 =20
1.31
+++ src/modules/frontend/text/text.c 15 Feb 2003 10:36:21 -0000
@@ -495,14 +495,14 @@
int width =3D getwidth();
char out[256];
- ui->progress_cur +=3D step;
-
snprintf(out, sizeof(out), "[%.1f%%] %s",
(double)(ui->progress_cur - ui->progress_min) /
(double)(ui->progress_max - ui->progress_min) * 100.0, info);
if (strlen(out) > width - 7)
out[width - 7] =3D 0;
+ ui->progress_cur +=3D step;
+
printf("%s\r", out);
fflush(stdout);
}
@@ -510,7 +510,7 @@
static void text_progress_stop(struct frontend *ui)
{
INFO(INFO_DEBUG, "%s\n", __FUNCTION__);
-
+ text_progress_step(ui, 0, "");
printf("\n");
}
--=-UMLPC8eCUBwuWxurf2A0
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: Detta =?ISO-8859-1?Q?=E4r?= en digitalt signerad
meddelandedel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQA+ThhmGpBPiZwE9FYRAkANAJ953T+5nU/bQuOsLxnQP2ovZOtTEgCgpVwv
0TBJs6pA9sag7224l9UZIYI=
=5+rC
-----END PGP SIGNATURE-----
--=-UMLPC8eCUBwuWxurf2A0--
---------------------------------------
Received: (at 181088-close) by bugs.debian.org; 21 Feb 2003 23:38:24 +0000
>From katie@auric.debian.org Fri Feb 21 17:38:24 2003
Return-path: <katie@auric.debian.org>
Received: from auric.debian.org [206.246.226.45] (mail)
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18mMkK-0004b7-00; Fri, 21 Feb 2003 17:38:24 -0600
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 18mMeI-0007pp-00; Fri, 21 Feb 2003 18:32:10 -0500
From: Martin Sjogren <sjogren@debian.org>
To: 181088-close@bugs.debian.org
X-Katie: $Revision: 1.32 $
Subject: Bug#181088: fixed in cdebconf 0.31
Message-Id: <E18mMeI-0007pp-00@auric.debian.org>
Sender: Archive Administrator <katie@auric.debian.org>
Date: Fri, 21 Feb 2003 18:32:10 -0500
Delivered-To: 181088-close@bugs.debian.org
We believe that the bug you reported is fixed in the latest version of
cdebconf, which is due to be installed in the Debian FTP archive:
cdebconf-slang-udeb_0.31_i386.udeb
to pool/main/c/cdebconf/cdebconf-slang-udeb_0.31_i386.udeb
cdebconf-udeb_0.31_i386.udeb
to pool/main/c/cdebconf/cdebconf-udeb_0.31_i386.udeb
cdebconf_0.31.dsc
to pool/main/c/cdebconf/cdebconf_0.31.dsc
cdebconf_0.31.tar.gz
to pool/main/c/cdebconf/cdebconf_0.31.tar.gz
cdebconf_0.31_i386.deb
to pool/main/c/cdebconf/cdebconf_0.31_i386.deb
libdebconf1-dev_0.31_i386.deb
to pool/main/c/cdebconf/libdebconf1-dev_0.31_i386.deb
libdebconf1_0.31_i386.deb
to pool/main/c/cdebconf/libdebconf1_0.31_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 181088@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Martin Sjogren <sjogren@debian.org> (supplier of updated cdebconf package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Fri, 21 Feb 2003 23:53:53 +0100
Source: cdebconf
Binary: libdebconf1 cdebconf-udeb cdebconf-slang-udeb cdebconf libdebconf1-dev
Architecture: source i386
Version: 0.31
Distribution: unstable
Urgency: low
Maintainer: Debian Install System Team <debian-boot@lists.debian.org>
Changed-By: Martin Sjogren <sjogren@debian.org>
Description:
cdebconf - Debian Configuration Management System (C-implementation)
cdebconf-slang-udeb - S-Lang frontend for Debian Configuration Management System (udeb)
cdebconf-udeb - Debian Configuration Management System (C-implementation) (udeb)
libdebconf1 - Debian Configuration Management System (C-implementation)
libdebconf1-dev - Development files for cdebconf
Closes: 180299 181081 181083 181088
Changes:
cdebconf (0.31) unstable; urgency=low
.
* Petter Reinholdtsen
- Added Norwegian Bokmål translations received from Bjørn Steensrud.
* Max Kosmach <max@tcen.ru>: initial russian translation
* Denis Barbier
- With the slang frontend, cursor must skip <Cancel> button even
when it is not displayed. (Closes: #180299)
* Thorsten Sauter
- Added basic progress bar support fo shellscripts (Closes: #181083).
* Martin Sjögren
- Text frontend: Blank until end of line when updating progress bar
(Closes: #181081).
- Text frontend: Increase the progress step *after* printing, so it
won't say 100% until it's done (Closes: #181088).
Files:
da8b5653b56c492180be39a691d37d3f 857 utils optional cdebconf_0.31.dsc
0d0345c02375bc42169ed85df7c80248 536896 utils optional cdebconf_0.31.tar.gz
d33018c0305912a1ccad5869691c2483 170312 devel optional libdebconf1-dev_0.31_i386.deb
0ee7f8f29cb61c8053f19277c832c116 26918 libs optional libdebconf1_0.31_i386.deb
deae5fa08ce5d5f6cd1ce924bf9e2ba8 66086 utils optional cdebconf_0.31_i386.deb
1e5245c0b12bc6aa5c1fa117145705d3 40130 debian-installer standard cdebconf-udeb_0.31_i386.udeb
8d8e4d7ae47fc0fcd439bee93f08a9eb 6990 debian-installer standard cdebconf-slang-udeb_0.31_i386.udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+VrTNGpBPiZwE9FYRAqXLAJ4suEeFu38GFxAUyRxXkkkVf3HSWgCfUVjo
S3C56OWA/NzsWXrr9EdkQdk=
=I+rH
-----END PGP SIGNATURE-----
Reply to: