Re: [d-i][patch] patch against netcfg

[Tollef Fog Heen <tollef@add.no>]

* Thomas Poindessous 

| I attached a second patch which contains some fixes you didn't applied.
| It fixes : 
| - length of buffer for command. the length of the command for GNU is
| greater than 128. Example:
| settrans -fg /servers/socket/2 /hurd/pfinet --interface=eth0 --address=127.127.127.127
| --netmask=255.255.255.221 --gateway=127.127.127.128
| 
| 139 chars (without '\0').

ah, I didn't understand why you increased that buffer.  I doubled it
to 256 bytes now; should be enough.

| - there is a missing ',' in a line

fixed, thanks.

| > no, it doesn't, at leastI couldn't find documentation which supports
| > your statement (nor anything which contradicts it -- I am rather safe
| > than sorry, so until you can give me a pointer to some docs saying
| > that you are right, I will keep them there).
| 
| I did some tests before sending you this patch, it worked with adding
| '\0'. It works because di_snprintfcat use vsnprintf which adds '\0'. But, I
| will send you a test to be sure.

I'm not sure if the string will get too long and such -- I need to
check it properly.  I might be wrong, though.

-- 
Tollef Fog Heen                                                        ,''`.
UNIX is user friendly, it's just picky about who its friends are      : :' :
                                                                      `. `' 
                                                                        `-  


-- 
To UNSUBSCRIBE, email to debian-boot-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org