Re: Change to the validator in the makefile of po dir
reopen 138679
retitle 138679 newt can't handle long list boxes
reassign 138679 newt
quit
Wed, May 22, 2002 at 03:17:31PM +0200 wrote:
> Hello,
>
> Here is a patch to the makefile of dbootstrap/po dir, to check against too
> long messages. It relies on comments to the translators of the good format,
> and that could be improoved.
Cool :-) I think translator comments is the best we can do. IMO, There
isn't a good way to automatically tell which messages are going into a
newtListBox(), someone really needs to read the code. The culprit is
newt.
>
> Can I commit it, or do you have any objections ?
It looks great. Two things:
1. maybe a note indicating that if and when 138679 is fixed this test
can go away, as well as all the TRANS notes?
2. if I read it correctly though the special handling of main_menu.c
isn't very maintainable when the file changes. We're relying on line
numbers to stay the same, right? Perhaps we just need a bunch of
'TRANS' messages in main_menu.c.
-David
>
> Thanks, Mt.
> Index: Makefile
> ===================================================================
> RCS file: /cvs/debian-boot/boot-floppies/utilities/dbootstrap/po/Makefile,v
> retrieving revision 1.50
> diff -u -r1.50 Makefile
> --- Makefile 2002/03/16 15:04:39 1.50
> +++ Makefile 2002/05/22 13:17:28
> @@ -39,6 +39,20 @@
> check-%: %.po
> @echo -n "$<: "
> @msgfmt -o /dev/null --statistics -c -v $<
> + @echo "Check for long messages..."
> + @pb=`grep -n --after-context=4 'keep this under one line' $< |\
> + sed 's/./\0 -> /81' | grep ' -> [^"]'`; \
> + if test "x$$pb" != "x"; then \
> + echo " Some messages must be less than 63 chars.";\
> + echo "$$pb;"; \
> + fi;\
> + pb=`grep -n --after-context=4 '^\#:.*main_menu.c:1[5-9][0-9]\|^\#:.*main_menu.c:2[0-2][0-9]' $< | \
> + grep '\"' | sed 's/./\0 -> /67' | grep ' -> [^"]'` ; \
> + if test "x$$pb" != "x"; then \
> + echo " Some messages seem to have to be less than 48 chars.";\
> + echo " (see lists.debian.org/debian-boot/2002/debian-boot-200204/msg00375.html)";\
> + echo "$$pb;"; \
> + fi
>
> update-%: %.po $(PACKAGE).pot
> cat=`basename $<`; \
--
To UNSUBSCRIBE, email to debian-boot-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: