Bug#146479: `defaults' keyword in /etc/fstab is often useless
Package: boot-floppies
Version: 3.0.22
Severity: wishlist
Tags: patch
I wish the /etc/fstab file to fit in 80 columns if possible, so that
it is more readable in console. It usually does not because the
installation program seems to think "defaults" is a required option,
but in fact this keyword is only useful when it's alone, so that there
is actually a fourth field. When there are more mount options this
"defaults" keyword is completely redundant and useless.
The following patch removes the use of "defaults" only when there are more
options to follow, it also removes a tab from the banner line so that
it fits in 80 columns.
--- orig.baseconfig.c Fri May 10 11:49:35 2002
+++ baseconfig.c Fri May 10 11:55:29 2002
@@ -317,18 +317,18 @@
}
else if (is_fstype("/target", "ext3")) {
fsname = "ext3";
- fsopts = "defaults,errors=remount-ro";
+ fsopts = "errors=remount-ro";
pass = 1;
}
else if (is_fstype("/target", "ext2")) {
fsname = "ext2";
- fsopts = "defaults,errors=remount-ro";
+ fsopts = "errors=remount-ro";
pass = 1;
}
else if (is_fstype("/target", "reiserfs")) {
fsname = "reiserfs";
if (need_notail("/target"))
- fsopts = "defaults,notail";
+ fsopts = "notail";
else
fsopts = "defaults";
pass = 0; /* fsck is unusable */
@@ -341,7 +341,7 @@
fprintf(fstab,
_("# /etc/fstab: static file system information.\n"
"#\n"
- "# <file system>\t<mount point>\t<type>\t<options>\t\t\t<dump>\t<pass>\n"));
+ "# <file system>\t<mount point>\t<type>\t<options>\t\t<dump>\t<pass>\n"));
fprintf(fstab,
"%s\t/\t\t%s\t%s\t0\t%d\n",
Root->name, fsname, fsopts, pass);
@@ -359,8 +359,8 @@
fprintf(fstab,
"proc\t\t/proc\t\tproc\tdefaults\t\t\t0\t0\n");
fprintf(fstab,
- "/dev/fd0\t/floppy\t\tauto\tdefaults,user,noauto\t\t0\t0\n"
- "/dev/cdrom\t/cdrom\t\tiso9660\tdefaults,ro,user,noauto\t\t0\t0\n");
+ "/dev/fd0\t/floppy\t\tauto\tuser,noauto\t\t0\t0\n"
+ "/dev/cdrom\t/cdrom\t\tiso9660\tro,user,noauto\t\t0\t0\n");
proc = fopen ("/proc/mounts", "r");
if ( proc == NULL )
--
To UNSUBSCRIBE, email to debian-boot-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
Reply to: