[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Small cleanup for utilities/dbootstrap/release_notes.c



[Petter Reinholdtsen]
> BTW: The test code is unable to test other languages.  Should this be
> fixed?

If it should be fixed, here is a patch to fix it.

release_notes_test seem to be broken for all non-english texts.  I've
tested de and da.  The width calculation fails.

Index: release_notes.c
===================================================================
RCS file: /cvs/debian-boot/boot-floppies/utilities/dbootstrap/release_notes.c,v
retrieving revision 1.9
diff -u -3 -p -u -r1.9 release_notes.c
--- release_notes.c     2002/03/01 12:30:27     1.9
+++ release_notes.c     2002/03/11 17:10:40
@@ -9,8 +9,10 @@

 #ifdef _TESTING_
 #  define RELEASE_FILE "../../scripts/rootdisk/messages/C/release_notes"
+#  define RELEASE_FILE_FMT "../../scripts/rootdisk/messages/%s/release_notes"
 #else
 #  define RELEASE_FILE "/release_notes"
+#  define RELEASE_FILE_FMT "/release_notes.%S"
 #endif

 int
@@ -22,7 +24,7 @@ release_notes (const char *suffix)
     char *fname = (char *)malloc (PATH_MAX);

     if (suffix != NULL)
-        snprintf (fname, PATH_MAX, "%s.%s", RELEASE_FILE, suffix);
+        snprintf (fname, PATH_MAX, RELEASE_FILE_FMT, suffix);
     else
         strcpy (fname, RELEASE_FILE);



Reply to: