Re: Patch for Bug#120386: lilo misconfigured

[Marcin Owsiany <porridge@debian.org>]

On Sat, Feb 02, 2002 at 01:02:22AM +0100, Michael Tiedtke wrote:
> This solves the bug, but could someone please explain me why it
> doesn't work in the original code?
> 
> Old:
>    if ( (res = menuBox(prtbuf, _("Where should the LILO boot loader be installed?"), opt, 2, 1) == -1 ))
>    ...
>  The return value of menuBox is not assigned to res.
>  It still has the inital value of 0.

Maybe gcc understands:

res = menuBox(..) == -1

as:

res = (menuBox(..) == -1)

and not as:

(res = menuBox(..)) == -1

Marcin
-- 
Marcin Owsiany <porridge@debian.org>             http://marcin.owsiany.pl/
GnuPG: 1024D/60F41216  FE67 DA2D 0ACA FC5E 3F75  D6F6 3A0D 8AA0 60F4 1216